From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68055C5519F for ; Mon, 16 Nov 2020 13:37:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE8F922245 for ; Mon, 16 Nov 2020 13:37:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Qv/uxgQs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE8F922245 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keegm-00038B-LM for qemu-devel@archiver.kernel.org; Mon, 16 Nov 2020 08:37:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keegB-0002an-IN for qemu-devel@nongnu.org; Mon, 16 Nov 2020 08:36:23 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:39799) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1keeg8-0003LI-Qw for qemu-devel@nongnu.org; Mon, 16 Nov 2020 08:36:23 -0500 Received: by mail-wr1-x444.google.com with SMTP id o15so18716171wru.6 for ; Mon, 16 Nov 2020 05:36:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=1ubJJlH9rfte8+pUGPT5fJGB+P3KWcyR5Xhz7Eq0wQo=; b=Qv/uxgQslJmb+ZD0djxrBv7NMeR7zBpwB4PiRJ0EsU4uezvQvoEUzEkTqgdHxPdSUh WOdNbDTegPp6bHxTto+eSsWmCEEH3cX1BgG3TKcqWOQnkAY2m9ZRElaBXZT68aTpcf7b YG+bfuPWracV54yEZFctS0I0jBwm4M3+wiRykqioSDvASsi4goGwFFG4yVdAEdVwcBJn cwLIr91sp/x+pGnzHnQmwrSJgZMaqVe+5+ZgfkqmuP3E1qMoUV1uRbo9p3ODQr0kZeHO /czwXPHetorwxXBMlNIzg+kd6I+igJhJ4v/qqHvaI+jrUnFfv5snW/ZO4D7kVAphJsIv /Edg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=1ubJJlH9rfte8+pUGPT5fJGB+P3KWcyR5Xhz7Eq0wQo=; b=ez7fa/wHiJYvZ/hBqW5vVmJjsiPHx6hSrQVkE7mStl9z3zsXKubI7yewBEyaZagUlD /Sv6zKYutosstRxo0U50aBEHeO+ikwZO4Q1TtsNPRhmY6Y+wMIjKIBnHsQWuJev6q8GP mqREw8D5X1zI83reV+QvVTjtRpM93tEaagyFY6ZrxbEQpBro/ygYX8LJe2Tf1Voc2oPC BETmDjQO8xOGfv4O/GqIe7/sdsn0Kis5qmgnXxLuiASspNcQW4Me8MzhaHfgR7SJijzv w3qc2sRGWsl5CggATfHKbLoVR5aTXCtqcuZkg3T/wfRqK31d512H8SJ85HguSYs/tC3g ceLg== X-Gm-Message-State: AOAM532ERHF+q2K+w/2S3HlHJQmCZqF9OtIf4NIq5HCQLRohnd/AxQ8W mE/hhJewcV9m8bOws3mkoXk+Zg== X-Google-Smtp-Source: ABdhPJxZIChO3DPXHVR9hOQmoAnN1LPQJR99VkoBh31qWTI0kcRylJRbQW3nCdq51Dl1EGx/wTx+Rg== X-Received: by 2002:a05:6000:89:: with SMTP id m9mr19571523wrx.412.1605533779174; Mon, 16 Nov 2020 05:36:19 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id a131sm19683212wmh.30.2020.11.16.05.36.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 05:36:17 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 9CB811FF7E; Mon, 16 Nov 2020 13:36:16 +0000 (GMT) References: <20201116024810.2415819-1-kuhn.chenqun@huawei.com> <20201116024810.2415819-4-kuhn.chenqun@huawei.com> User-agent: mu4e 1.5.7; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Chen Qun Subject: Re: [PATCH v3 3/7] accel/tcg/user-exec: silence the compiler warnings In-reply-to: <20201116024810.2415819-4-kuhn.chenqun@huawei.com> Date: Mon, 16 Nov 2020 13:36:16 +0000 Message-ID: <87v9e5whin.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::444; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x444.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , zhang.zhanghailiang@huawei.com, qemu-trivial@nongnu.org, Riku Voipio , Richard Henderson , Philippe =?utf-8?Q?Mathieu-Dau?= =?utf-8?Q?d=C3=A9?= , qemu-devel@nongnu.org, ganqixin@huawei.com, Euler Robot , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Chen Qun writes: > When using -Wimplicit-fallthrough in our CFLAGS on GCC9, the compiler sho= wed warning: > ../accel/tcg/user-exec.c: In function =E2=80=98handle_cpu_signal=E2=80=99: > ../accel/tcg/user-exec.c:169:13: warning: this statement may fall through= [-Wimplicit-fallthrough=3D] > 169 | cpu_exit_tb_from_sighandler(cpu, old_set); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ../accel/tcg/user-exec.c:172:9: note: here > 172 | default: > > Mark the cpu_exit_tb_from_sighandler() function with QEMU_NORETURN to fix= it. > > Reported-by: Euler Robot > Signed-off-by: Chen Qun > Reviewed-by: Richard Henderson > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Reviewed-by: Thomas Huth Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e