From: "Alex Bennée" <alex.bennee@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Cleber Rosa <crosa@redhat.com>
Subject: Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs
Date: Fri, 07 Feb 2020 11:08:15 +0000 [thread overview]
Message-ID: <87v9oi7izk.fsf@linaro.org> (raw)
In-Reply-To: <5d0def0e-0943-3345-784d-80f8ccc318b9@redhat.com>
Thomas Huth <thuth@redhat.com> writes:
> On 03/02/2020 04.23, Cleber Rosa wrote:
>> This is a crude and straightforward mapping of Peter's
>> "remake-merge-builds" and "pull-buildtest" scripts.
<snip>
>
> Thanks for doing this! The patch looks basically fine to me, but some
> comments below...
>
<snip>
>
> Question to Peter/Alex/Stefan/Howevermergespullreqsinthefuture:
>
> Should the above jobs really be skipped for pull requests, or would it
> be ok to include them there, too? (in the latter case, the above changes
> could just be dropped)
I think there is certainly value in having different stages of testing.
At least initially we'll want to match as closely to the current system
and then I imagine as we go on there will be trade-offs to be made in
how much is gating PRs and how much is retroactive and catches things
that slip through. While more testing is good we can't exponentially
grow what is reasonable to test for on all PRs.
<snip>
--
Alex Bennée
next prev parent reply other threads:[~2020-02-07 11:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 3:23 [RFC PATCH 1/2] GitLab CI: avoid calling before_scripts on unintended jobs Cleber Rosa
2020-02-03 3:23 ` [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs Cleber Rosa
2020-02-03 17:36 ` Wainer dos Santos Moschetta
2020-02-07 19:34 ` Cleber Rosa
2020-02-08 13:02 ` Peter Maydell
2020-03-10 5:01 ` Cleber Rosa
2020-03-10 9:30 ` Peter Maydell
2020-02-06 13:03 ` Philippe Mathieu-Daudé
2020-02-06 13:05 ` Philippe Mathieu-Daudé
2020-03-10 3:53 ` Cleber Rosa
2020-02-06 13:52 ` Wainer dos Santos Moschetta
2020-02-06 13:54 ` Philippe Mathieu-Daudé
2020-02-06 15:13 ` Thomas Huth
2020-02-07 8:37 ` Thomas Huth
2020-02-07 10:05 ` Thomas Huth
2020-02-07 11:08 ` Alex Bennée [this message]
2020-02-07 19:59 ` Cleber Rosa
2020-02-07 16:26 ` Peter Maydell
2020-02-07 19:27 ` Cleber Rosa
2020-02-08 12:51 ` Peter Maydell
2020-02-07 19:46 ` Cleber Rosa
2020-02-03 15:26 ` [RFC PATCH 1/2] GitLab CI: avoid calling before_scripts on unintended jobs Wainer dos Santos Moschetta
2020-02-03 16:08 ` Thomas Huth
2020-02-07 20:01 ` Cleber Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9oi7izk.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).