* [PATCH] migration: Fix the re-run check of the migrate-incoming command
@ 2019-11-13 17:53 Yury Kotov
2019-11-14 13:50 ` Darren Kenny
2020-01-08 13:56 ` Juan Quintela
0 siblings, 2 replies; 3+ messages in thread
From: Yury Kotov @ 2019-11-13 17:53 UTC (permalink / raw)
To: Dr. David Alan Gilbert, Juan Quintela; +Cc: qemu-devel, yc-core
The current check sets an error but doesn't fail the command.
This may cause a problem if new connection attempt by the same URI
affects the first connection.
Signed-off-by: Yury Kotov <yury-kotov@yandex-team.ru>
---
migration/migration.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/migration.c b/migration/migration.c
index 354ad072fa..fa2005b49f 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1784,6 +1784,7 @@ void qmp_migrate_incoming(const char *uri, Error **errp)
}
if (!once) {
error_setg(errp, "The incoming migration has already been started");
+ return;
}
qemu_start_incoming_migration(uri, &local_err);
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] migration: Fix the re-run check of the migrate-incoming command
2019-11-13 17:53 [PATCH] migration: Fix the re-run check of the migrate-incoming command Yury Kotov
@ 2019-11-14 13:50 ` Darren Kenny
2020-01-08 13:56 ` Juan Quintela
1 sibling, 0 replies; 3+ messages in thread
From: Darren Kenny @ 2019-11-14 13:50 UTC (permalink / raw)
To: Yury Kotov; +Cc: qemu-devel, Dr. David Alan Gilbert, yc-core, Juan Quintela
On Wed, Nov 13, 2019 at 08:53:25PM +0300, Yury Kotov wrote:
>The current check sets an error but doesn't fail the command.
>This may cause a problem if new connection attempt by the same URI
>affects the first connection.
>
>Signed-off-by: Yury Kotov <yury-kotov@yandex-team.ru>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
>---
> migration/migration.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/migration/migration.c b/migration/migration.c
>index 354ad072fa..fa2005b49f 100644
>--- a/migration/migration.c
>+++ b/migration/migration.c
>@@ -1784,6 +1784,7 @@ void qmp_migrate_incoming(const char *uri, Error **errp)
> }
> if (!once) {
> error_setg(errp, "The incoming migration has already been started");
>+ return;
> }
>
> qemu_start_incoming_migration(uri, &local_err);
>--
>2.24.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] migration: Fix the re-run check of the migrate-incoming command
2019-11-13 17:53 [PATCH] migration: Fix the re-run check of the migrate-incoming command Yury Kotov
2019-11-14 13:50 ` Darren Kenny
@ 2020-01-08 13:56 ` Juan Quintela
1 sibling, 0 replies; 3+ messages in thread
From: Juan Quintela @ 2020-01-08 13:56 UTC (permalink / raw)
To: Yury Kotov; +Cc: Dr. David Alan Gilbert, yc-core, qemu-devel
Yury Kotov <yury-kotov@yandex-team.ru> wrote:
> The current check sets an error but doesn't fail the command.
> This may cause a problem if new connection attempt by the same URI
> affects the first connection.
>
> Signed-off-by: Yury Kotov <yury-kotov@yandex-team.ru>
Reviewed-by: Juan Quintela <quintela@redhat.com>
queued
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-08 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-13 17:53 [PATCH] migration: Fix the re-run check of the migrate-incoming command Yury Kotov
2019-11-14 13:50 ` Darren Kenny
2020-01-08 13:56 ` Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).