From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DED8ECE59D for ; Tue, 15 Oct 2019 21:35:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6566F20872 for ; Tue, 15 Oct 2019 21:35:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="djRL1xwM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6566F20872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKUTO-0003PR-Jr for qemu-devel@archiver.kernel.org; Tue, 15 Oct 2019 17:35:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59409) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKUSd-0002jA-4x for qemu-devel@nongnu.org; Tue, 15 Oct 2019 17:34:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKUSb-0005em-QF for qemu-devel@nongnu.org; Tue, 15 Oct 2019 17:34:30 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:45349) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKUSb-0005dS-GR for qemu-devel@nongnu.org; Tue, 15 Oct 2019 17:34:29 -0400 Received: by mail-wr1-x443.google.com with SMTP id r5so25516186wrm.12 for ; Tue, 15 Oct 2019 14:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=APbKRHUXiL5lF9Bbs65raEsPMkit3brRQPt/e3Yu1jc=; b=djRL1xwM3jaPtoFNMoFl03VDtFuu0Qn+Qx+Ifs+MBn8qIciIgreXkKVeOasluRLWxh /ZP8XeoQo4snr3ugQUXC3bSU565djOFJCWyU14PkLhQsYnN5swL/NNulSZveOSP7l1ko HD5TmQmNKCu/3jbBv+Pr8FENax6d728o17Ct+IAZOrPARRZLmBLunqwnlnJrEtVGFw9D T8tgwwagI4KRTkzyYHofiA8cJs12r6lVmI6ZriCenRxGMXH5Q9M6jcx4GLxe9U+UJWco R6tEzb/oPzDZj1Qn1cf7y1YUv4iD3gzeVlq+7iOx1Gapn3+T0/gq2XVkZKcSyYHBJDgm X5Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=APbKRHUXiL5lF9Bbs65raEsPMkit3brRQPt/e3Yu1jc=; b=GD2nnSCJe4qUPwDrl+9p28ouseLiyMTEqG+OfgDeVRm8VXXFukEgWW7j8WNnWpTPH+ YzbhKIAOUCkRr8BZB8steEYEgKbndM1LZ+DKgg6W/5XlCJdgVGqir/7dGmVbVlos9yBX K6suaOfSahrn3zngqEgvw/NXtNyIoahMqROBQX4gnCvN+gQJPULTRZwPRtybeft6pq0r n02DI76RROs0b9PH7PmxWnpuoVT3Mn3SN8zjzhRTT5MLXc8raWoXdzTemCPrXCcnrALd mNiKbxsFrZhZtvyv5lmvGIhkd6/1Kt2DATIOmxVwRNC/xGDhbKlHpLH48RJ4i5IaSWtQ TDYQ== X-Gm-Message-State: APjAAAXGRtpm/GyK1MV7vf2fvkFoFdnVwYhi/zioierExmjNTdHdol7s Vuy4jD6pB32iRsAKsK2Zi1nkLw== X-Google-Smtp-Source: APXvYqzYslMFXxNYuGSzZGVFHDTKNyeWC1ny/pfQctYuINC212XdBBO7ZMqsDH3UQLKCbqblJ0yeAg== X-Received: by 2002:a5d:694e:: with SMTP id r14mr34930186wrw.232.1571175267908; Tue, 15 Oct 2019 14:34:27 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id t83sm859404wmt.18.2019.10.15.14.34.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2019 14:34:27 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 64A9F1FF87; Tue, 15 Oct 2019 22:34:26 +0100 (BST) References: <20191014104948.4291-1-alex.bennee@linaro.org> <20191014104948.4291-24-alex.bennee@linaro.org> <87zhi1ltyo.fsf@linaro.org> User-agent: mu4e 1.3.5; emacs 27.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Peter Maydell Subject: Re: [PATCH v5 23/55] translator: add translator_ld{ub,sw,uw,l,q} In-reply-to: <87zhi1ltyo.fsf@linaro.org> Date: Tue, 15 Oct 2019 22:34:26 +0100 Message-ID: <87v9splml9.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robert.foley@futurewei.com, Richard Henderson , QEMU Developers , peter.puhov@futurewei.com, Aaron Lindsay , "Emilio G. Cota" , Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Alex Benn=C3=A9e writes: > Peter Maydell writes: > >> On Mon, 14 Oct 2019 at 12:38, Alex Benn=C3=A9e = wrote: >>> >>> From: "Emilio G. Cota" >>> >>> We don't bother with replicating the fast path (tlb_hit) of the old >>> cpu_ldst helpers as it has no measurable effect on performance. This >>> probably indicates we should consider flattening the whole set of >>> helpers but that is out of scope for this change. >>> >>> Suggested-by: Richard Henderson >>> Signed-off-by: Emilio G. Cota >>> [AJB: directly plumb into softmmu/user helpers] >>> Signed-off-by: Alex Benn=C3=A9e >>> >>> diff --git a/tcg/tcg.h b/tcg/tcg.h >>> index a38659ea5b..302533b463 100644 >>> --- a/tcg/tcg.h >>> +++ b/tcg/tcg.h >>> @@ -1317,6 +1317,7 @@ uint64_t helper_be_ldq_cmmu(CPUArchState *env, ta= rget_ulong addr, >>> # define helper_ret_stl_mmu helper_be_stl_mmu >>> # define helper_ret_stq_mmu helper_be_stq_mmu >>> # define helper_ret_ldw_cmmu helper_be_ldw_cmmu >>> +# define helper_ret_lduw_cmmu helper_be_ldw_cmmu >>> # define helper_ret_ldl_cmmu helper_be_ldl_cmmu >>> # define helper_ret_ldq_cmmu helper_be_ldq_cmmu >>> #else >>> @@ -1330,6 +1331,7 @@ uint64_t helper_be_ldq_cmmu(CPUArchState *env, ta= rget_ulong addr, >>> # define helper_ret_stl_mmu helper_le_stl_mmu >>> # define helper_ret_stq_mmu helper_le_stq_mmu >>> # define helper_ret_ldw_cmmu helper_le_ldw_cmmu >>> +# define helper_ret_lduw_cmmu helper_le_ldw_cmmu >>> # define helper_ret_ldl_cmmu helper_le_ldl_cmmu >>> # define helper_ret_ldq_cmmu helper_le_ldq_cmmu >>> #endif >> >> This looks odd. Why is it ok to define a 'lduw' helper >> as the 'ldw' cmmu helper ? One ought to be sign >> extending and the other not... > > This was attempting to make things line up between the softmmu helpers > and the user-mode ld*_p helpers that we need to expand to. I'm not sure > a sign extending loader even makes sense for code load anyway. That last bit is not true as sign extending helpers are used for loading sign-extended immediate values. > >> >> thanks >> -- PMM -- Alex Benn=C3=A9e