From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] configure: Do not display host compilers as cross-compilers
Date: Wed, 04 Jul 2018 16:41:30 +0100 [thread overview]
Message-ID: <87va9v80ut.fsf@linaro.org> (raw)
In-Reply-To: <20180704143014.8670-1-f4bug@amsat.org>
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> This silent (since d75402b5ee2):
>
> ./configure
> [...]
> NOTE: cross-compilers enabled: 'cc'
>
> Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Reported-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index b99ebdde24..fbb53ab6bb 100755
> --- a/configure
> +++ b/configure
> @@ -7328,7 +7328,7 @@ echo "QEMU_CFLAGS+=$cflags" >> $config_target_mak
>
> done # for target in $targets
>
> -if test -n "$enabled_cross_compilers"; then
> +if test -n "$target_compiler" -a -n "$enabled_cross_compilers"; then
> echo
> echo "NOTE: cross-compilers enabled: $enabled_cross_compilers"
> fi
I had also added:
- echo "NOTE: cross-compilers enabled: $enabled_cross_compilers"
+ echo "NOTE: compilers enabled for TCG tests: $enabled_cross_compilers"
to make things clearer.
Acked-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
next prev parent reply other threads:[~2018-07-04 15:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 14:30 [Qemu-devel] [PATCH] configure: Do not display host compilers as cross-compilers Philippe Mathieu-Daudé
2018-07-04 14:45 ` Cornelia Huck
2018-07-04 15:41 ` Alex Bennée [this message]
2018-07-04 15:48 ` Daniel P. Berrangé
2018-07-04 16:21 ` Alex Bennée
2018-07-04 16:26 ` Daniel P. Berrangé
2018-07-04 16:36 ` Philippe Mathieu-Daudé
2018-07-04 18:12 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va9v80ut.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).