From: "Alex Bennée" <alex.bennee@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: MTTCG Devel <mttcg@greensocs.com>,
Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Cota@braap.org, Sergey Fedorov <serge.fdrv@gmail.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] Should we introduce a TranslationRegion with its own codegen buffer?
Date: Mon, 04 Apr 2016 13:01:02 +0100 [thread overview]
Message-ID: <87vb3xtwg1.fsf@linaro.org> (raw)
In-Reply-To: <57025113.7000101@redhat.com>
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 04/04/2016 13:24, Alex Bennée wrote:
>> FWIW I've dropped the patch that moves tb_find_fast out of tb_lock in
>> the upcoming base-patches-v2 series because it:
>> - weirdly breaks the pxe tests
>
> I'm happy to take a look.
Be my guest:
https://github.com/stsquad/qemu/tree/mttcg/base-patches-v2-with-tb-fast-delock
It breaks on i386 and x86_64 softmmu targets with make check. I also got
a command line failing with a dump of the pxe bootfile and handbuilt seabios:
./x86_64-softmmu/qemu-system-x86_64 -display vnc=:0 -machine accel=tcg
-netdev user,id=net0,tftp=./,bootfile=tests/pxe-test-disk.raw -device
virtio-net-pci,netdev=net0,romfile=pc-bios/pxe-virtio.rom -chardev
stdio,id=seabios -device isa-debugcon,iobase=0x402,chardev=seabios -bios roms/seabios/out/bios.bin
>
>> - is pretty ugly anyway
>
> What exactly makes it ugly?
Subjective I guess but the use of tb_lock_recursive() and
tb_lock_reset() seem not as clean as they could be. Is this stuff Fred
re-introduced?
>
> Paolo
>
>> This is obviously going to have an impact on performance which bought me
>> back to should we be thinking more holistically about how to approach
>> this problem.
--
Alex Bennée
next prev parent reply other threads:[~2016-04-04 12:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 8:54 [Qemu-devel] Should we introduce a TranslationRegion with its own codegen buffer? Alex Bennée
2016-04-04 9:01 ` Paolo Bonzini
2016-04-04 10:39 ` Sergey Fedorov
2016-04-04 11:24 ` Alex Bennée
2016-04-04 11:33 ` Paolo Bonzini
2016-04-04 12:01 ` Alex Bennée [this message]
2016-04-04 12:13 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb3xtwg1.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=Cota@braap.org \
--cc=mttcg@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=serge.fdrv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).