From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an3Bs-0000rG-Oo for qemu-devel@nongnu.org; Mon, 04 Apr 2016 08:01:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1an3Bo-0003Io-Mv for qemu-devel@nongnu.org; Mon, 04 Apr 2016 08:01:08 -0400 Received: from mail-lf0-x230.google.com ([2a00:1450:4010:c07::230]:34088) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an3Bo-0003Ij-Di for qemu-devel@nongnu.org; Mon, 04 Apr 2016 08:01:04 -0400 Received: by mail-lf0-x230.google.com with SMTP id c62so166852630lfc.1 for ; Mon, 04 Apr 2016 05:01:04 -0700 (PDT) References: <87y48tu53d.fsf@linaro.org> <57022D7A.1040507@redhat.com> <57024478.2080506@gmail.com> <87wpodty5d.fsf@linaro.org> <57025113.7000101@redhat.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <57025113.7000101@redhat.com> Date: Mon, 04 Apr 2016 13:01:02 +0100 Message-ID: <87vb3xtwg1.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] Should we introduce a TranslationRegion with its own codegen buffer? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: MTTCG Devel , Peter Maydell , QEMU Developers , Cota@braap.org, Sergey Fedorov , Richard Henderson Paolo Bonzini writes: > On 04/04/2016 13:24, Alex Bennée wrote: >> FWIW I've dropped the patch that moves tb_find_fast out of tb_lock in >> the upcoming base-patches-v2 series because it: >> - weirdly breaks the pxe tests > > I'm happy to take a look. Be my guest: https://github.com/stsquad/qemu/tree/mttcg/base-patches-v2-with-tb-fast-delock It breaks on i386 and x86_64 softmmu targets with make check. I also got a command line failing with a dump of the pxe bootfile and handbuilt seabios: ./x86_64-softmmu/qemu-system-x86_64 -display vnc=:0 -machine accel=tcg -netdev user,id=net0,tftp=./,bootfile=tests/pxe-test-disk.raw -device virtio-net-pci,netdev=net0,romfile=pc-bios/pxe-virtio.rom -chardev stdio,id=seabios -device isa-debugcon,iobase=0x402,chardev=seabios -bios roms/seabios/out/bios.bin > >> - is pretty ugly anyway > > What exactly makes it ugly? Subjective I guess but the use of tb_lock_recursive() and tb_lock_reset() seem not as clean as they could be. Is this stuff Fred re-introduced? > > Paolo > >> This is obviously going to have an impact on performance which bought me >> back to should we be thinking more holistically about how to approach >> this problem. -- Alex Bennée