From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32985)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1a9aFB-0001i9-Rh
	for qemu-devel@nongnu.org; Thu, 17 Dec 2015 10:13:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1a9aF6-00076K-Rp
	for qemu-devel@nongnu.org; Thu, 17 Dec 2015 10:13:25 -0500
Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:35205)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1a9aF6-00075j-J0
	for qemu-devel@nongnu.org; Thu, 17 Dec 2015 10:13:20 -0500
Received: by mail-wm0-x232.google.com with SMTP id l126so25809355wml.0
	for <qemu-devel@nongnu.org>; Thu, 17 Dec 2015 07:13:20 -0800 (PST)
References: <1447946528-1533-1-git-send-email-eric.auger@linaro.org>
	<1447946528-1533-6-git-send-email-eric.auger@linaro.org>
	<87wpt4bv9i.fsf@linaro.org> <56727FDC.1040202@linaro.org>
	<87wpsdfbm6.fsf@linaro.org>
	<CAFEAcA8Pmu+Tb_RLXe97APgZEFqNB7SAR=miZkRo_WS_6R6_yQ@mail.gmail.com>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <CAFEAcA8Pmu+Tb_RLXe97APgZEFqNB7SAR=miZkRo_WS_6R6_yQ@mail.gmail.com>
Date: Thu, 17 Dec 2015 15:13:17 +0000
Message-ID: <87vb7xf6r6.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RESEND RFC 5/6] hw/arm/sysbus-fdt: helpers for
	clock node generation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: thomas.lendacky@amd.com, eric.auger@st.com, Eric Auger <eric.auger@linaro.org>, Patch Tracking <patches@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Alex Williamson <alex.williamson@redhat.com>, qemu-arm <qemu-arm@nongnu.org>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Paolo Bonzini <pbonzini@redhat.com>, Baptiste Reynal <b.reynal@virtualopensystems.com>, Christoffer Dall <christoffer.dall@linaro.org>


Peter Maydell <peter.maydell@linaro.org> writes:

> On 17 December 2015 at 13:28, Alex Bennée <alex.bennee@linaro.org> wrote:
>> Usually I would expect to see a pre-declaration of a function at the
>> head of the file and only if it is used before the actual definition of
>> the function. It doesn't make sense to pre-declare right before the
>> actual function definition itself.
>>
>> I'm surprised to hear the compiler complained, especially as nothing was
>> calling this function in this patch.
>
> The compiler complains if it sees a function which is not static
> and for which it hasn't previously seen a prototype, because
> generally this means that either (a) the function is file-local
> only and should have been declared static or (b) the function is
> not file-local but you forgot to put a prototype in a header so
> that other files can call it. (This is -Wmissing-prototypes.)


Ahh I see now. I guess if its declared static in this patch and not
used its going to complain about an unused function as well? Maybe that
suggests the patch should just be merged with patch where it is actually
used?

>
> thanks
> -- PMM


--
Alex Bennée