From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZopWk-0002ym-UM for qemu-devel@nongnu.org; Wed, 21 Oct 2015 05:17:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZopWj-0007U4-Uy for qemu-devel@nongnu.org; Wed, 21 Oct 2015 05:17:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZopWj-0007Tw-Q2 for qemu-devel@nongnu.org; Wed, 21 Oct 2015 05:17:45 -0400 From: Juan Quintela In-Reply-To: <1443515898-3594-54-git-send-email-dgilbert@redhat.com> (David Alan Gilbert's message of "Tue, 29 Sep 2015 09:38:17 +0100") References: <1443515898-3594-1-git-send-email-dgilbert@redhat.com> <1443515898-3594-54-git-send-email-dgilbert@redhat.com> Date: Wed, 21 Oct 2015 11:17:43 +0200 Message-ID: <87vba0a8co.fsf@neno.neno> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v8 53/54] Disable mlock around incoming postcopy Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: aarcange@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, luis@cs.umu.se, bharata@linux.vnet.ibm.com, amit.shah@redhat.com, pbonzini@redhat.com "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Userfault doesn't work with mlock; mlock is designed to nail down pages > so they don't move, userfault is designed to tell you when they're not > there. > > munlock the pages we userfault protect before postcopy. > mlock everything again at the end if mlock is enabled. > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: David Gibson > Reviewed-by: Amit Shah Reviewed-by: Juan Quintela