From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrOjS-0000H9-Qx for qemu-devel@nongnu.org; Mon, 02 Jun 2014 05:40:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrOjO-0001li-Fq for qemu-devel@nongnu.org; Mon, 02 Jun 2014 05:40:42 -0400 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:37292 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrOjO-0001le-3o for qemu-devel@nongnu.org; Mon, 02 Jun 2014 05:40:38 -0400 References: <1401434911-26992-1-git-send-email-edgar.iglesias@gmail.com> <1401434911-26992-2-git-send-email-edgar.iglesias@gmail.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1401434911-26992-2-git-send-email-edgar.iglesias@gmail.com> Date: Mon, 02 Jun 2014 10:40:34 +0100 Message-ID: <87vbsjsl7x.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v1 01/16] target-arm: A64: Break out aarch64_save/restore_sp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Edgar E. Iglesias" Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, rob.herring@linaro.org, aggelerf@ethz.ch, qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com, john.williams@xilinx.com, greg.bellows@linaro.org, pbonzini@redhat.com, christoffer.dall@linaro.org, rth@twiddle.net Edgar E. Iglesias writes: > From: "Edgar E. Iglesias" > > Break out code to save/restore AArch64 SP into functions. > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/internals.h | 29 ++++++++++++++++++++--------- > target-arm/kvm64.c | 13 +++---------- > target-arm/op_helper.c | 6 +----- > 3 files changed, 24 insertions(+), 24 deletions(-) > > diff --git a/target-arm/internals.h b/target-arm/internals.h > index 564b5fa..08fa697 100644 > --- a/target-arm/internals.h > +++ b/target-arm/internals.h > @@ -105,6 +105,24 @@ enum arm_fprounding { > > int arm_rmode_to_sf(int rmode); > > +static inline void aarch64_save_sp(CPUARMState *env, int el) > +{ > + if (env->pstate & PSTATE_SP) { > + env->sp_el[el] = env->xregs[31]; > + } else { > + env->sp_el[0] = env->xregs[31]; > + } > +} > + > +static inline void aarch64_restore_sp(CPUARMState *env, int el) > +{ > + if (env->pstate & PSTATE_SP) { > + env->xregs[31] = env->sp_el[el]; > + } else { > + env->xregs[31] = env->sp_el[0]; > + } > +} > + Just a note to say I'm currently looking at rationalising env->pstate/env->uncached_cpsr and the various access functions. However conveniently this moves everything to one place so I approve ;-) > static inline void update_spsel(CPUARMState *env, uint32_t imm) > { > unsigned int cur_el = arm_current_pl(env); > @@ -114,21 +132,14 @@ static inline void update_spsel(CPUARMState *env, uint32_t imm) > if (!((imm ^ env->pstate) & PSTATE_SP)) { > return; > } > + aarch64_save_sp(env, cur_el); > env->pstate = deposit32(env->pstate, 0, 1, imm); > > /* We rely on illegal updates to SPsel from EL0 to get trapped > * at translation time. > */ > assert(cur_el >= 1 && cur_el <= 3); > - if (env->pstate & PSTATE_SP) { > - /* Switch from using SP_EL0 to using SP_ELx */ > - env->sp_el[0] = env->xregs[31]; > - env->xregs[31] = env->sp_el[cur_el]; > - } else { > - /* Switch from SP_EL0 to SP_ELx */ > - env->sp_el[cur_el] = env->xregs[31]; > - env->xregs[31] = env->sp_el[0]; > - } > + aarch64_restore_sp(env, cur_el); > } > > /* Valid Syndrome Register EC field values */ > diff --git a/target-arm/kvm64.c b/target-arm/kvm64.c > index 70f311b..0542cd1 100644 > --- a/target-arm/kvm64.c > +++ b/target-arm/kvm64.c > @@ -21,6 +21,7 @@ > #include "sysemu/kvm.h" > #include "kvm_arm.h" > #include "cpu.h" > +#include "internals.h" > #include "hw/arm/arm.h" > > static inline void set_feature(uint64_t *features, int feature) > @@ -124,11 +125,7 @@ int kvm_arch_put_registers(CPUState *cs, int level) > /* KVM puts SP_EL0 in regs.sp and SP_EL1 in regs.sp_el1. On the > * QEMU side we keep the current SP in xregs[31] as well. > */ > - if (env->pstate & PSTATE_SP) { > - env->sp_el[1] = env->xregs[31]; > - } else { > - env->sp_el[0] = env->xregs[31]; > - } > + aarch64_save_sp(env, 1); > > reg.id = AARCH64_CORE_REG(regs.sp); > reg.addr = (uintptr_t) &env->sp_el[0]; > @@ -227,11 +224,7 @@ int kvm_arch_get_registers(CPUState *cs) > /* KVM puts SP_EL0 in regs.sp and SP_EL1 in regs.sp_el1. On the > * QEMU side we keep the current SP in xregs[31] as well. > */ > - if (env->pstate & PSTATE_SP) { > - env->xregs[31] = env->sp_el[1]; > - } else { > - env->xregs[31] = env->sp_el[0]; > - } > + aarch64_restore_sp(env, 1); > > reg.id = AARCH64_CORE_REG(regs.pc); > reg.addr = (uintptr_t) &env->pc; > diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c > index b28f694..2e2429a 100644 > --- a/target-arm/op_helper.c > +++ b/target-arm/op_helper.c > @@ -391,11 +391,7 @@ void HELPER(exception_return)(CPUARMState *env) > uint32_t spsr = env->banked_spsr[spsr_idx]; > int new_el, i; > > - if (env->pstate & PSTATE_SP) { > - env->sp_el[cur_el] = env->xregs[31]; > - } else { > - env->sp_el[0] = env->xregs[31]; > - } > + aarch64_save_sp(env, cur_el); > > env->exclusive_addr = -1; Reviewed-by: Alex Bennée -- Alex Bennée