From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46393)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1WSrgC-0002zm-Uz
	for qemu-devel@nongnu.org; Wed, 26 Mar 2014 13:32:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1WSrg8-0007ac-Gu
	for qemu-devel@nongnu.org; Wed, 26 Mar 2014 13:31:56 -0400
Received: from static.88-198-71-155.clients.your-server.de
	([88.198.71.155]:56881 helo=socrates.bennee.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1WSrg8-0007aN-9x
	for qemu-devel@nongnu.org; Wed, 26 Mar 2014 13:31:52 -0400
References: <1395844634-11729-1-git-send-email-alex.bennee@linaro.org>
	<1395844634-11729-4-git-send-email-alex.bennee@linaro.org>
	<5332F6FD.6050200@codeaurora.org>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <5332F6FD.6050200@codeaurora.org>
Date: Wed, 26 Mar 2014 17:32:05 +0000
Message-ID: <87vbv0zx0q.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RFC PATCH 3/4] qemu-log: new option -dfilter to
	limit output
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christopher Covington <cov@codeaurora.org>
Cc: Anthony Liguori <aliguori@amazon.com>, "Michael
	S. Tsirkin" <mst@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Michael Walle <michael@walle.cc>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>


Christopher Covington <cov@codeaurora.org> writes:

> Hi Alex,
>
> Neat series.
>
> On 03/26/2014 10:37 AM, alex.bennee@linaro.org wrote:
>> From: Alex Bennée <alex.bennee@linaro.org>
>> 
>> When debugging big programs or system emulation sometimes you want both
>> the verbosity of cpu,exec et all but don't want to generate lots of logs
>> for unneeded stuff. This patch adds a new option -dfilter which allows
>> you to specify interesting address ranges in the form:
>> 
>>   -dfilter 0x8000-0x9000,0xffffffc000080000+0x200,...
>> 
>> Then logging code can use the new qemu_log_in_addr_range() function to
>> decide if it will output logging information for the given range.
>> 
>
>> diff --git a/qemu-options.hx b/qemu-options.hx
>> index ee5437b..a5cd095 100644
>> --- a/qemu-options.hx
>> +++ b/qemu-options.hx
>> @@ -2667,6 +2667,15 @@ STEXI
>>  Output log in @var{logfile} instead of to stderr
>>  ETEXI
>>  
>> +DEF("dfilter", HAS_ARG, QEMU_OPTION_DFILTER, \
>> +    "-dfilter range,..  filter debug output to range of addresses (useful for -d cpu,exec,etc..)\n",
>> +    QEMU_ARCH_ALL)
>
> It might be helpful to include a quick note in the documentation about the
> format of range (based on your commit message and the code, I take it that
> "a-b" means <a to b> while "a+b" means <a to a+b>).

Indeed. I shall try and update the relevant bits to make nice docs
useful ;-)

>
> Thanks,
> Christopher

-- 
Alex Bennée