From: Anthony Liguori <anthony@codemonkey.ws>
To: Alexey Kardashevskiy <aik@ozlabs.ru>,
David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] spapr-pci: change endianness for io ports space
Date: Mon, 15 Jul 2013 10:02:42 -0500 [thread overview]
Message-ID: <87vc4bamst.fsf@codemonkey.ws> (raw)
In-Reply-To: <51E2A614.5010402@ozlabs.ru>
Alexey Kardashevskiy <aik@ozlabs.ru> writes:
> On 07/13/2013 06:03 PM, David Gibson wrote:
>> On Fri, Jul 12, 2013 at 05:37:19PM +1000, Alexey Kardashevskiy wrote:
>>> sPAPR PHB emulates IO ports on PCI via a special memory region which
>>> routes all reads/writes further via cpu_in*/cpu_out* which are eventually
>>> processed by MemoryRegionOps implemented by devices.
>
>> Hrm. That double dispatch was a workaround for bugs in the plain
>> memory region dispatching which meant we couldn't directly map regions
>> in memory space to IO areas.
>>
>> It would be worth checking if that workaround is still necessary.
>
> Hm. Good point, thanks! It seems memory_region_init_io is not necessary any
> more. Will make a patch for it.
You should try the latest qemu.git commit. There shouldn't be a problem
anymore.
Regards,
Anthony Liguori
>
>
> --
> Alexey
next prev parent reply other threads:[~2013-07-15 15:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 7:37 [Qemu-devel] [PATCH] spapr-pci: change endianness for io ports space Alexey Kardashevskiy
2013-07-12 8:59 ` [Qemu-devel] BUG report " Alexey Kardashevskiy
2013-07-12 11:25 ` Alexander Graf
2013-07-13 8:03 ` [Qemu-devel] " David Gibson
2013-07-14 13:22 ` Alexey Kardashevskiy
2013-07-15 15:02 ` Anthony Liguori [this message]
2013-07-15 23:06 ` Alexey Kardashevskiy
2013-07-16 0:28 ` Anthony Liguori
2013-07-16 0:39 ` Alexey Kardashevskiy
2013-07-16 2:05 ` Anthony Liguori
2013-07-16 2:17 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vc4bamst.fsf@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).