From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UykId-0005yA-G9 for qemu-devel@nongnu.org; Mon, 15 Jul 2013 11:02:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UykIc-0005WD-AG for qemu-devel@nongnu.org; Mon, 15 Jul 2013 11:02:51 -0400 Received: from mail-ie0-f172.google.com ([209.85.223.172]:33717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UykIc-0005Vs-5W for qemu-devel@nongnu.org; Mon, 15 Jul 2013 11:02:50 -0400 Received: by mail-ie0-f172.google.com with SMTP id 16so26130856iea.31 for ; Mon, 15 Jul 2013 08:02:49 -0700 (PDT) From: Anthony Liguori In-Reply-To: <51E2A614.5010402@ozlabs.ru> References: <1373614639-15523-1-git-send-email-aik@ozlabs.ru> <20130713080309.GA11522@voom.redhat.com> <51E2A614.5010402@ozlabs.ru> Date: Mon, 15 Jul 2013 10:02:42 -0500 Message-ID: <87vc4bamst.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] spapr-pci: change endianness for io ports space List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , David Gibson Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf Alexey Kardashevskiy writes: > On 07/13/2013 06:03 PM, David Gibson wrote: >> On Fri, Jul 12, 2013 at 05:37:19PM +1000, Alexey Kardashevskiy wrote: >>> sPAPR PHB emulates IO ports on PCI via a special memory region which >>> routes all reads/writes further via cpu_in*/cpu_out* which are eventually >>> processed by MemoryRegionOps implemented by devices. > >> Hrm. That double dispatch was a workaround for bugs in the plain >> memory region dispatching which meant we couldn't directly map regions >> in memory space to IO areas. >> >> It would be worth checking if that workaround is still necessary. > > Hm. Good point, thanks! It seems memory_region_init_io is not necessary any > more. Will make a patch for it. You should try the latest qemu.git commit. There shouldn't be a problem anymore. Regards, Anthony Liguori > > > -- > Alexey