From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60025)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1UUHKU-0005r3-85
	for qemu-devel@nongnu.org; Mon, 22 Apr 2013 10:02:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1UUHKP-0001TE-Ke
	for qemu-devel@nongnu.org; Mon, 22 Apr 2013 10:02:50 -0400
Received: from mail-oa0-f45.google.com ([209.85.219.45]:43904)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1UUHKP-0001Sw-G6
	for qemu-devel@nongnu.org; Mon, 22 Apr 2013 10:02:45 -0400
Received: by mail-oa0-f45.google.com with SMTP id o17so5918656oag.32
	for <qemu-devel@nongnu.org>; Mon, 22 Apr 2013 07:02:44 -0700 (PDT)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <51753505.9020107@redhat.com>
References: <1366346658-4680-1-git-send-email-akong@redhat.com>
	<5172BD04.2050504@redhat.com>
	<20130422073252.GC1938@t430s.nay.redhat.com>
	<20130422080935.GA29975@t430s.nay.redhat.com>
	<517503E0.1080906@redhat.com> <20130422084350.17b2941b@redhat.com>
	<51753505.9020107@redhat.com>
Date: Mon, 22 Apr 2013 09:02:41 -0500
Message-ID: <87vc7ewtmm.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH] monitor: intervally send down events to
	guest in hold time
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>
Cc: Amos Kong <akong@redhat.com>, kraxel@redhat.com, qemu-devel@nongnu.org

Paolo Bonzini <pbonzini@redhat.com> writes:

> Il 22/04/2013 14:43, Luiz Capitulino ha scritto:
>>> > 
>>> > You're right.  The typematic delay/rate is implemented within the i8042
>>> > keyboard microcontroller (QEMU does not implement that register).
>>> > 
>>> > It is possible that software ignores interrupts for a key that is
>>> > already down, and reimplements autorepeat in software, but your patch is
>>> > correct.
>> But isn't this patch the equivalent of repeatedly pressing and releasing a
>> key? Shouldn't this be implemented at a lower-level layer like the input
>> subsystem?
>
> No, this patch is implementing what the microcontroller does, i.e. 10
> presses + 1 release.  I'm not sure it is the right level to do it (the
> rate/delay should be at least customizable from the board), but the
> logic is right and if someone else needs more configurability we can add
> it later.

Regardless, this is a compat breaker IMHO.  This is a dramatically
different semantic behavior.

What's the use-case here?

Regards,

Anthony Liguori

>
> Paolo