From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42636) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPfbe-0004ZK-Cz for qemu-devel@nongnu.org; Tue, 09 Apr 2013 16:57:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPfbc-0002We-AV for qemu-devel@nongnu.org; Tue, 09 Apr 2013 16:57:30 -0400 Received: from mail-ob0-x229.google.com ([2607:f8b0:4003:c01::229]:48026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPfbc-0002WO-2v for qemu-devel@nongnu.org; Tue, 09 Apr 2013 16:57:28 -0400 Received: by mail-ob0-f169.google.com with SMTP id wp18so6698934obc.28 for ; Tue, 09 Apr 2013 13:57:27 -0700 (PDT) From: Anthony Liguori In-Reply-To: <516479BC.30206@greensocs.com> References: <1365495755-10902-1-git-send-email-hdegoede@redhat.com> <5163D31F.5060901@redhat.com> <87a9p7h606.fsf@codemonkey.ws> <516479BC.30206@greensocs.com> Date: Tue, 09 Apr 2013 15:57:24 -0500 Message-ID: <87vc7vpgln.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: KONRAD =?utf-8?B?RnLDqWTDqXJpYw==?= Cc: Paolo Bonzini , qemu-devel , Hans de Goede KONRAD Fr=C3=A9d=C3=A9ric writes: > On 09/04/2013 21:13, Anthony Liguori wrote: >> Paolo Bonzini writes: >> >>> Il 09/04/2013 10:22, Hans de Goede ha scritto: >>>> Signed-off-by: Hans de Goede >>>> Cc: Paolo Bonzini >>>> --- >>>> hw/9pfs/virtio-9p-device.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion >>> Ouch, /me installs libcap-ng-devel. >> On a fresh F18, I tried to find all the deps needed that can be >> reasonably installed. This is what I came up with: >> >> # yum install xen-devel iasl libfdt-devel libcap-ng-devel \ >> spice-server-devel gnutls-devel cyrus-sasl-devel libjpeg-turbo-devel \ >> libpng-devel uuid-devel xfsprogs-devel ncurses-devel brlapi-devel \ >> libcurl-devel bluez-libs-devel libiscsi-devel libcap-ng-devel \ >> spice-protocol SDL-devel libcap-devel usbredir-devel libseccomp-devel= \ >> ceph-devel >> >> Still missing GlusterFS, VDE, and iscsi. F18 doesn't seem to >> package these at appropriate versions. >> >> Regards, >> >> Anthony Liguori > Isn't libattr-devel needed as well for virtio-9p? I have CONFIG_VIRTFS=3Dy without libattr-devel installed FWIW. Regards, Anthony Liguori > > I needed it to test my patch-set this morning. >> >>> Thanks. >>> >>> Paolo >>> >>>> diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c >>>> index 43f930e..b476b81 100644 >>>> --- a/hw/9pfs/virtio-9p-device.c >>>> +++ b/hw/9pfs/virtio-9p-device.c >>>> @@ -12,11 +12,11 @@ >>>> */ >>>>=20=20=20 >>>> #include "hw/virtio/virtio.h" >>>> +#include "hw/virtio/virtio-9p.h" >>>> #include "hw/i386/pc.h" >>>> #include "qemu/sockets.h" >>>> #include "virtio-9p.h" >>>> #include "fsdev/qemu-fsdev.h" >>>> -#include "virtio-9p-device.h" >>>> #include "virtio-9p-xattr.h" >>>> #include "virtio-9p-coth.h" >>>>=20=20=20 >>>>