From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDxTh-0004ST-HA for qemu-devel@nongnu.org; Fri, 08 Mar 2013 08:36:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDxTZ-0003H3-0U for qemu-devel@nongnu.org; Fri, 08 Mar 2013 08:36:53 -0500 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:44494) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDxTY-0003Ga-FC for qemu-devel@nongnu.org; Fri, 08 Mar 2013 08:36:44 -0500 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 8 Mar 2013 23:28:47 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id D22BF2BB004F for ; Sat, 9 Mar 2013 00:36:36 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r28DaXJo64487570 for ; Sat, 9 Mar 2013 00:36:33 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r28Daaqe012469 for ; Sat, 9 Mar 2013 00:36:36 +1100 From: Anthony Liguori In-Reply-To: <87a9qel3v0.fsf@blackfin.pond.sub.org> References: <20130307184647.GA31012@redhat.com> <87d2vbx9rz.fsf@blackfin.pond.sub.org> <20130307202309.GA13088@redhat.com> <87a9qel3v0.fsf@blackfin.pond.sub.org> Date: Fri, 08 Mar 2013 07:36:28 -0600 Message-ID: <87vc92dndv.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v4] qdev: DEVICE_DELETED event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , "Michael S. Tsirkin" Cc: Kevin Wolf , Eduardo Habkost , libvir-list@redhat.com, Stefan Hajnoczi , qemu-devel@nongnu.org, Luiz Capitulino , Gerd Hoffmann , Paolo Bonzini , Andreas =?utf-8?Q?F=C3=A4rber?= Markus Armbruster writes: > "Michael S. Tsirkin" writes: > >> On Thu, Mar 07, 2013 at 08:57:52PM +0100, Markus Armbruster wrote: >>> "Michael S. Tsirkin" writes: >>> >>> > libvirt has a long-standing bug: when removing the device, >>> > it can request removal but does not know when the >>> > removal completes. Add an event so we can fix this in a robust way. >>> > >>> > Signed-off-by: Michael S. Tsirkin >>> >>> Speaking as the acting QMP maintainer, just to avoid misunderstandings: >>> there's disagreement on the event's design, namely when it should fire, >>> and how it should name the device. I don't want the discussion >>> preempted by a commit. >> >> Yes, you are asking for more functionality, but can I add this in a >> follow-up commit please? I prefer this patch as is, as it can be >> backported to stable branches and downstreams. Upstream a follow up >> patch can add fields and more triggers which won't apply to any >> downstreams. > > If you want to address my review comments in a separate patch, go right > ahead. Please post both together as a series, for coherent review and > to simplify patch tracking. > > I'm asking for two things: > > 1. Event member path. Fair to call this "more functionality". I agree > that backporting it to pre-QOM versions isn't practical. > > 2. Sane event trigger condition: on any device deletion, not just when > the device happens to have a qdev ID. This isn't "more", it's > "different". Ack. Regards, Anthony Liguori