From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwEgy-0004uy-7y for qemu-devel@nongnu.org; Fri, 18 Jan 2013 11:21:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TwEgx-0002we-0T for qemu-devel@nongnu.org; Fri, 18 Jan 2013 11:21:20 -0500 Received: from mail-ie0-f177.google.com ([209.85.223.177]:58303) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwEd0-00024m-CY for qemu-devel@nongnu.org; Fri, 18 Jan 2013 11:17:14 -0500 Received: by mail-ie0-f177.google.com with SMTP id k13so6507041iea.36 for ; Fri, 18 Jan 2013 08:17:13 -0800 (PST) From: Anthony Liguori In-Reply-To: <1358525049-31163-1-git-send-email-armbru@redhat.com> References: <1358525049-31163-1-git-send-email-armbru@redhat.com> Date: Fri, 18 Jan 2013 10:17:11 -0600 Message-ID: <87vcau5uuw.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 0/3] Purge the silly GLib Basic Types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: blauwirbel@gmail.com Markus Armbruster writes: > See PATCH 1/3 for rationale. > > Markus Armbruster (3): > Purge the silly GLib "Basic Types", except for gboolean > Purge GLib's gboolean, it's a trap for the unwary > checkpatch: Keep out the GLib silliness we just purged Changing QEMU code to work around checkpatch's failing is insane. When interacting with glib, use glib types. Not using those types just makes the code more difficult to understand. Regards, Anthony Liguori > > async.c | 12 +++++------- > coroutine-gthread.c | 8 ++++---- > hw/9pfs/virtio-9p-coth.c | 2 +- > hw/fw_cfg.c | 6 +++--- > hw/qdev-monitor.c | 2 +- > hw/qdev.c | 4 ++-- > hw/xen_disk.c | 6 +++--- > include/qom/object.h | 8 ++++---- > main-loop.c | 2 +- > qapi/opts-visitor.c | 10 +++++----- > qapi/qmp-input-visitor.c | 4 ++-- > qemu-img.c | 4 ++-- > qga/channel-posix.c | 25 +++++++++++++------------ > qga/channel-win32.c | 26 +++++++++++++------------- > qga/channel.h | 10 +++++----- > qga/commands-posix.c | 6 +++--- > qga/commands.c | 2 +- > qga/guest-agent-command-state.c | 4 ++-- > qga/guest-agent-core.h | 2 +- > qga/main.c | 16 ++++++++-------- > qom/container.c | 2 +- > qom/object.c | 26 +++++++++++++------------- > qtest.c | 8 ++++---- > scripts/checkpatch.pl | 29 +++++++++++++++++++++++++++++ > target-alpha/cpu.c | 4 ++-- > target-arm/cpu.c | 2 +- > target-arm/helper.c | 4 ++-- > target-i386/cpu.c | 2 +- > target-m68k/helper.c | 4 ++-- > target-openrisc/cpu.c | 4 ++-- > target-ppc/translate_init.c | 12 ++++++------ > tests/libqtest.c | 20 ++++++++++---------- > tests/test-visitor-serialization.c | 12 ++++++------ > trace/simple.c | 8 ++++---- > vl.c | 6 +++--- > 35 files changed, 165 insertions(+), 137 deletions(-) > > -- > 1.7.11.7