From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ti5E7-0006vw-CQ for qemu-devel@nongnu.org; Mon, 10 Dec 2012 10:25:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ti5Dx-0001Y5-Kh for qemu-devel@nongnu.org; Mon, 10 Dec 2012 10:25:03 -0500 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:35944) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ti5Dx-0001Ue-0V for qemu-devel@nongnu.org; Mon, 10 Dec 2012 10:24:53 -0500 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 10 Dec 2012 20:54:24 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id E4F2C3940045 for ; Mon, 10 Dec 2012 20:54:45 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qBAFOf9s33095822 for ; Mon, 10 Dec 2012 20:54:44 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qBAFOggc005347 for ; Tue, 11 Dec 2012 02:24:42 +1100 From: Anthony Liguori In-Reply-To: References: <1355149790-8125-1-git-send-email-aliguori@us.ibm.com> <1355149790-8125-2-git-send-email-aliguori@us.ibm.com> Date: Mon, 10 Dec 2012 09:24:33 -0600 Message-ID: <87vcca7wwe.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 1/4] savevm: introduce little endian variants of savevm routines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Rusty Russell , "Michael S. Tsirkin" , qemu-devel@nongnu.org, David Gibson Peter Maydell writes: > On 10 December 2012 14:29, Anthony Liguori wrote: >> Signed-off-by: Anthony Liguori >> --- >> qemu-file.h | 7 +++++++ >> savevm.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 52 insertions(+) >> >> diff --git a/qemu-file.h b/qemu-file.h >> index d64bdbb..ac5286c 100644 >> --- a/qemu-file.h >> +++ b/qemu-file.h >> @@ -94,6 +94,9 @@ static inline void qemu_put_ubyte(QEMUFile *f, unsigned int v) >> void qemu_put_be16(QEMUFile *f, unsigned int v); >> void qemu_put_be32(QEMUFile *f, unsigned int v); >> void qemu_put_be64(QEMUFile *f, uint64_t v); >> +void qemu_put_le16(QEMUFile *f, unsigned int v); >> +void qemu_put_le32(QEMUFile *f, unsigned int v); >> +void qemu_put_le64(QEMUFile *f, uint64_t v); > > Do we want to add a comment here somewhere that says the le versions > are for backcompat with a specific thing and the be ones are the > ones to use in new code (well, new code not using vmstate)? Yeah, that's a good idea. I've unfortunately found a couple more cases of this (writing native endian to the wire). Regards, Anthony Liguori > > -- PMM