From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36841)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Te9Ns-0000IF-1w
	for qemu-devel@nongnu.org; Thu, 29 Nov 2012 14:02:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Te9Nm-0006kV-4Z
	for qemu-devel@nongnu.org; Thu, 29 Nov 2012 14:02:51 -0500
Received: from mail-ie0-f173.google.com ([209.85.223.173]:63415)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Te9Nl-0006jx-VU
	for qemu-devel@nongnu.org; Thu, 29 Nov 2012 14:02:46 -0500
Received: by mail-ie0-f173.google.com with SMTP id e13so11879856iej.4
	for <qemu-devel@nongnu.org>; Thu, 29 Nov 2012 11:02:45 -0800 (PST)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <20121129141015.GG9625@redhat.com>
References: <20121022111824.GA6916@amit.redhat.com>
	<1350913800.90009.YahooMailClassic@web163904.mail.gq1.yahoo.com>
	<20121023125503.GG19977@stefanha-thinkpad.redhat.com>
	<20121101091918.GA19405@amit.redhat.com>
	<20121101120410.GC3993@redhat.com>
	<20121101160721.GA9176@redhat.com>
	<20121127162504.GA6210@redhat.com>
	<20121128215308.GA23360@redhat.com>
	<20121129130446.GA4429@amit.redhat.com>
	<20121129141015.GG9625@redhat.com>
Date: Thu, 29 Nov 2012 13:02:40 -0600
Message-ID: <87vccomdv3.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, Amit Shah <amit.shah@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Bug 1066055 <1066055@bugs.launchpad.net>, qemu-devel@nongnu.org, Edivaldo de Araujo Pereira <edivaldoapereira@yahoo.com.br>

"Michael S. Tsirkin" <mst@redhat.com> writes:

> On Thu, Nov 29, 2012 at 06:34:46PM +0530, Amit Shah wrote:
>> On (Wed) 28 Nov 2012 [23:53:08], Michael S. Tsirkin wrote:
>> > On Tue, Nov 27, 2012 at 06:25:04PM +0200, Michael S. Tsirkin wrote:
>> > > On Thu, Nov 01, 2012 at 06:07:21PM +0200, Michael S. Tsirkin wrote:
>> > > > Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced
>> > > > a regression in virtio-net performance because it looks
>> > > > into the ring aggressively while we really only care
>> > > > about a single packet worth of buffers.
>> > > > To fix, add parameters limiting lookahead, and
>> > > > use in virtqueue_avail_bytes.
>> > > > 
>> > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> > > > Reported-by: Edivaldo de Araujo Pereira <edivaldoapereira@yahoo.com.br>
>> > > 
>> > > Ping.
>> > > Anthony - going to apply this?
>> > 
>> > virtio rng was added since so naturally build broke.
>> > Here's a patch on top to fix it up. I never used virtio rng before so
>> > could not test at this hour, but it does fix the build.
>> > 
>> > I'll take a look at how to test it tomorrow but any
>> > info would be appreciated.
>> > Amit could you pls review?
>> 
>> Looks fine, I assume you will send a v2 of the patch to Anthony?
>> 
>> 		Amit
>
>
> Anthony volunteered to test this so there will only be v2 if he sees
> problems.

I need a Signed-off-by so why don't you just go ahead and send a v2 and
I'll test that.

Regards,

Anthony Liguori