From: Anthony Liguori <aliguori@us.ibm.com>
To: Eric Blake <eblake@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-opts: introduce a function to compare option names
Date: Wed, 25 Jul 2012 12:34:42 -0500 [thread overview]
Message-ID: <87vchb218t.fsf@codemonkey.ws> (raw)
In-Reply-To: <501022EF.2090700@redhat.com>
Eric Blake <eblake@redhat.com> writes:
> On 07/25/2012 10:45 AM, Eric Blake wrote:
>> On 07/25/2012 10:25 AM, Anthony Liguori wrote:
>>> We don't use the standard C functions for conversion because we don't want to
>>> depend on the user's locale. All option names in QEMU are en_US in plain ASCII.
>>
>>>
>>> +static int opt_tolower(int ch)
>>> +{
>>> + if (ch >= 'A' && ch <= 'Z') {
>>> + return 'a' + (ch - 'A');
>
> P.S. This is not portable to EBCDIC, but I guess we don't care about
> compilation of qemu on a non-ASCII machine, so my review still stands.
Fortunately, even on S390, Linux uses ASCII under normal circumstances
:-)
Regards,
Anthony Liguori
>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>>
>
> --
> Eric Blake eblake@redhat.com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
next prev parent reply other threads:[~2012-07-25 18:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 16:25 [Qemu-devel] [PATCH 0/2] Allow '-' or '_' for all QemuOpts Anthony Liguori
2012-07-25 16:25 ` [Qemu-devel] [PATCH 1/2] qemu-opts: introduce a function to compare option names Anthony Liguori
2012-07-25 16:45 ` Eric Blake
2012-07-25 16:46 ` Eric Blake
2012-07-25 17:34 ` Anthony Liguori [this message]
2012-07-25 16:53 ` Peter Maydell
2012-07-25 17:33 ` Anthony Liguori
2012-07-25 18:31 ` Peter Maydell
2012-07-27 7:44 ` Markus Armbruster
2012-07-27 11:14 ` Peter Maydell
2012-07-25 16:25 ` [Qemu-devel] [PATCH 2/2] qemu-config: convert all QemuOpts to use dashes instead of underscores Anthony Liguori
2012-07-25 17:32 ` Luiz Capitulino
2012-07-25 18:20 ` Anthony Liguori
2012-07-25 18:58 ` Peter Maydell
2012-07-25 19:02 ` Luiz Capitulino
2012-07-25 19:02 ` Peter Maydell
2012-07-25 19:09 ` [Qemu-devel] Changing qemu's -help output Luiz Capitulino
2012-07-25 21:21 ` [Qemu-devel] [libvirt] " Eric Blake
2012-07-27 7:45 ` [Qemu-devel] [PATCH 2/2] qemu-config: convert all QemuOpts to use dashes instead of underscores Markus Armbruster
2012-07-27 11:10 ` Andreas Färber
2012-07-25 17:34 ` [Qemu-devel] [PATCH 0/2] Allow '-' or '_' for all QemuOpts Luiz Capitulino
2012-07-27 8:39 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vchb218t.fsf@codemonkey.ws \
--to=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).