From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su6B2-0007ml-G3 for qemu-devel@nongnu.org; Wed, 25 Jul 2012 14:19:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Su6B1-0002Ip-2Q for qemu-devel@nongnu.org; Wed, 25 Jul 2012 14:19:16 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:55667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su6B0-0002IX-TT for qemu-devel@nongnu.org; Wed, 25 Jul 2012 14:19:14 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 25 Jul 2012 14:04:49 -0400 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 66F8E3C602CD for ; Wed, 25 Jul 2012 13:34:46 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6PHYkEL421020 for ; Wed, 25 Jul 2012 13:34:46 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6PHYjFi006856 for ; Wed, 25 Jul 2012 14:34:45 -0300 From: Anthony Liguori In-Reply-To: <501022EF.2090700@redhat.com> References: <1343233543-18561-1-git-send-email-aliguori@us.ibm.com> <1343233543-18561-2-git-send-email-aliguori@us.ibm.com> <5010228E.7070704@redhat.com> <501022EF.2090700@redhat.com> Date: Wed, 25 Jul 2012 12:34:42 -0500 Message-ID: <87vchb218t.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-opts: introduce a function to compare option names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Luiz Capitulino , qemu-devel@nongnu.org, Markus Armbruster Eric Blake writes: > On 07/25/2012 10:45 AM, Eric Blake wrote: >> On 07/25/2012 10:25 AM, Anthony Liguori wrote: >>> We don't use the standard C functions for conversion because we don't want to >>> depend on the user's locale. All option names in QEMU are en_US in plain ASCII. >> >>> >>> +static int opt_tolower(int ch) >>> +{ >>> + if (ch >= 'A' && ch <= 'Z') { >>> + return 'a' + (ch - 'A'); > > P.S. This is not portable to EBCDIC, but I guess we don't care about > compilation of qemu on a non-ASCII machine, so my review still stands. Fortunately, even on S390, Linux uses ASCII under normal circumstances :-) Regards, Anthony Liguori > >> Reviewed-by: Eric Blake >> > > -- > Eric Blake eblake@redhat.com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org