From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su6Qz-000402-81 for qemu-devel@nongnu.org; Wed, 25 Jul 2012 14:35:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Su6Qu-0007CT-JA for qemu-devel@nongnu.org; Wed, 25 Jul 2012 14:35:45 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:51551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su6Qu-0007CD-Eh for qemu-devel@nongnu.org; Wed, 25 Jul 2012 14:35:40 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 25 Jul 2012 14:35:38 -0400 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id E1925D10333 for ; Wed, 25 Jul 2012 14:20:19 -0400 (EDT) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6PIKIXc378658 for ; Wed, 25 Jul 2012 14:20:18 -0400 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6PIKDjE022468 for ; Wed, 25 Jul 2012 12:20:13 -0600 From: Anthony Liguori In-Reply-To: <20120725143258.52402998@doriath.home> References: <1343233543-18561-1-git-send-email-aliguori@us.ibm.com> <1343233543-18561-3-git-send-email-aliguori@us.ibm.com> <20120725143258.52402998@doriath.home> Date: Wed, 25 Jul 2012 13:20:10 -0500 Message-ID: <87vchbzorp.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-config: convert all QemuOpts to use dashes instead of underscores List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org, Markus Armbruster Luiz Capitulino writes: > On Wed, 25 Jul 2012 11:25:43 -0500 > Anthony Liguori wrote: > >> Signed-off-by: Anthony Liguori > > What about the man page? Should it be updated or are we going to let it > list options with "_"? The man page is generated from qemu-options.hx which also generates the help output. Unfortunately, we're still stuck in the "everyone yells at Anthony when he tries to change the help output because of libvirt" state. So we need to keep the option names in --help with '_'s. Regards, Anthony Liguori > >> --- >> qemu-config.c | 38 +++++++++++++++++++------------------- >> 1 files changed, 19 insertions(+), 19 deletions(-) >> >> diff --git a/qemu-config.c b/qemu-config.c >> index 5c3296b..1616547 100644 >> --- a/qemu-config.c >> +++ b/qemu-config.c >> @@ -91,11 +91,11 @@ static QemuOptsList qemu_drive_opts = { >> .type = QEMU_OPT_NUMBER, >> .help = "limit total I/O operations per second", >> },{ >> - .name = "iops_rd", >> + .name = "iops-rd", >> .type = QEMU_OPT_NUMBER, >> .help = "limit read operations per second", >> },{ >> - .name = "iops_wr", >> + .name = "iops-wr", >> .type = QEMU_OPT_NUMBER, >> .help = "limit write operations per second", >> },{ >> @@ -103,11 +103,11 @@ static QemuOptsList qemu_drive_opts = { >> .type = QEMU_OPT_NUMBER, >> .help = "limit total bytes per second", >> },{ >> - .name = "bps_rd", >> + .name = "bps-rd", >> .type = QEMU_OPT_NUMBER, >> .help = "limit read bytes per second", >> },{ >> - .name = "bps_wr", >> + .name = "bps-wr", >> .type = QEMU_OPT_NUMBER, >> .help = "limit write bytes per second", >> },{ >> @@ -230,7 +230,7 @@ QemuOptsList qemu_fsdev_opts = { >> .name = "path", >> .type = QEMU_OPT_STRING, >> }, { >> - .name = "security_model", >> + .name = "security-model", >> .type = QEMU_OPT_STRING, >> }, { >> .name = "writeout", >> @@ -243,7 +243,7 @@ QemuOptsList qemu_fsdev_opts = { >> .name = "socket", >> .type = QEMU_OPT_STRING, >> }, { >> - .name = "sock_fd", >> + .name = "sock-fd", >> .type = QEMU_OPT_NUMBER, >> }, >> >> @@ -263,10 +263,10 @@ QemuOptsList qemu_virtfs_opts = { >> .name = "path", >> .type = QEMU_OPT_STRING, >> }, { >> - .name = "mount_tag", >> + .name = "mount-tag", >> .type = QEMU_OPT_STRING, >> }, { >> - .name = "security_model", >> + .name = "security-model", >> .type = QEMU_OPT_STRING, >> }, { >> .name = "writeout", >> @@ -278,7 +278,7 @@ QemuOptsList qemu_virtfs_opts = { >> .name = "socket", >> .type = QEMU_OPT_STRING, >> }, { >> - .name = "sock_fd", >> + .name = "sock-fd", >> .type = QEMU_OPT_NUMBER, >> }, >> >> @@ -423,25 +423,25 @@ static QemuOptsList qemu_cpudef_opts = { >> .name = "stepping", >> .type = QEMU_OPT_NUMBER, >> },{ >> - .name = "feature_edx", /* cpuid 0000_0001.edx */ >> + .name = "feature-edx", >> .type = QEMU_OPT_STRING, >> },{ >> - .name = "feature_ecx", /* cpuid 0000_0001.ecx */ >> + .name = "feature-ecx", >> .type = QEMU_OPT_STRING, >> },{ >> - .name = "extfeature_edx", /* cpuid 8000_0001.edx */ >> + .name = "extfeature-edx", >> .type = QEMU_OPT_STRING, >> },{ >> - .name = "extfeature_ecx", /* cpuid 8000_0001.ecx */ >> + .name = "extfeature-ecx", >> .type = QEMU_OPT_STRING, >> },{ >> .name = "xlevel", >> .type = QEMU_OPT_NUMBER, >> },{ >> - .name = "model_id", >> + .name = "model-id", >> .type = QEMU_OPT_STRING, >> },{ >> - .name = "vendor_override", >> + .name = "vendor-override", >> .type = QEMU_OPT_NUMBER, >> }, >> { /* end of list */ } >> @@ -560,11 +560,11 @@ static QemuOptsList qemu_machine_opts = { >> .type = QEMU_OPT_STRING, >> .help = "accelerator list", >> }, { >> - .name = "kernel_irqchip", >> + .name = "kernel-irqchip", >> .type = QEMU_OPT_BOOL, >> .help = "use KVM in-kernel irqchip", >> }, { >> - .name = "kvm_shadow_mem", >> + .name = "kvm_shadow-mem", >> .type = QEMU_OPT_SIZE, >> .help = "KVM shadow MMU size", >> }, { >> @@ -588,11 +588,11 @@ static QemuOptsList qemu_machine_opts = { >> .type = QEMU_OPT_STRING, >> .help = "Dump current dtb to a file and quit", >> }, { >> - .name = "phandle_start", >> + .name = "phandle-start", >> .type = QEMU_OPT_STRING, >> .help = "The first phandle ID we may generate dynamically", >> }, { >> - .name = "dt_compatible", >> + .name = "dt-compatible", >> .type = QEMU_OPT_STRING, >> .help = "Overrides the \"compatible\" property of the dt root node", >> },