From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StndC-0002ak-Mz for qemu-devel@nongnu.org; Tue, 24 Jul 2012 18:31:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1StndB-0000wU-Qg for qemu-devel@nongnu.org; Tue, 24 Jul 2012 18:31:06 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:42592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StnWE-0007XN-EK for qemu-devel@nongnu.org; Tue, 24 Jul 2012 18:23:54 -0400 Received: from /spool/local by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 24 Jul 2012 16:23:52 -0600 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 7F53519D8039 for ; Tue, 24 Jul 2012 22:23:33 +0000 (WET) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6OMNawC167714 for ; Tue, 24 Jul 2012 16:23:36 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6OMNaKe010735 for ; Tue, 24 Jul 2012 16:23:36 -0600 From: Anthony Liguori In-Reply-To: <1343150454-4677-11-git-send-email-mdroth@linux.vnet.ibm.com> References: <1343150454-4677-1-git-send-email-mdroth@linux.vnet.ibm.com> <1343150454-4677-11-git-send-email-mdroth@linux.vnet.ibm.com> Date: Tue, 24 Jul 2012 17:23:33 -0500 Message-ID: <87vchckdcq.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 10/22] qapi: qapi.py, make json parser more robust List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , qemu-devel@nongnu.org Cc: quintela@redhat.com, owasserm@redhat.com, yamahata@valinux.co.jp, pbonzini@redhat.com, akong@redhat.com, afaerber@suse.de Michael Roth writes: > Currently the QAPI JSON parser expects a very particular style of code > indentation, the major one being that terminating curly/square brackets are > not on placed on a seperate line. This is incompatible with most > pretty-print formats, so make it a little more robust by supporting > these cases. The code was supposed to just expect that all subsequent lines are indented. This was to simplify the parser. Can you provide an problematic example? Regards, Anthony Liguori [...]