From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MG9z8-0005ky-6t for qemu-devel@nongnu.org; Mon, 15 Jun 2009 07:04:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MG9z3-0005iZ-54 for qemu-devel@nongnu.org; Mon, 15 Jun 2009 07:04:17 -0400 Received: from [199.232.76.173] (port=33317 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MG9z2-0005iW-VI for qemu-devel@nongnu.org; Mon, 15 Jun 2009 07:04:13 -0400 Received: from mx2.redhat.com ([66.187.237.31]:49411) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MG9z2-00035e-C4 for qemu-devel@nongnu.org; Mon, 15 Jun 2009 07:04:12 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5FB4BoY022795 for ; Mon, 15 Jun 2009 07:04:11 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5FB4B8H006287 for ; Mon, 15 Jun 2009 07:04:11 -0400 Received: from pike.pond.sub.org (vpn-10-40.str.redhat.com [10.32.10.40]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n5FB4Aor000829 for ; Mon, 15 Jun 2009 07:04:10 -0400 Subject: Re: [Qemu-devel] Re: [PATCH] Add -no-virtio-balloon command-line option References: <1244661817-3293-1-git-send-email-ehabkost@redhat.com> <4A300891.4060500@codemonkey.ws> <20090610193408.GE18045@blackpad> <4A30D748.8070507@redhat.com> <4A36138C.4060306@redhat.com> From: Markus Armbruster Date: Mon, 15 Jun 2009 13:04:09 +0200 In-Reply-To: <4A36138C.4060306@redhat.com> (Dor Laor's message of "Mon\, 15 Jun 2009 12\:25\:32 +0300") Message-ID: <87vdmx69na.fsf@pike.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Dor Laor writes: > Gerd Hoffmann wrote: >>> >>> This new option may be used to disable the virtio-balloon device. >>> >> >> ACK, looks good. >> >> And I can drop my lazy patch which just comments out virtio-balloon >> in the code ;) > > Actually, I rather have the balloon disabled by default. It's like any > other pci device which needs > explicit command line specification. Why consume a pci slot if not > implicitly required? I agree. The command line is plenty magic without implicitly added PCI devices. Besides, negative options -no-virtio-balloon lead to ugly double-negatives like if (!no_virtio_balloon).