From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LaAOE-0001o0-1g for qemu-devel@nongnu.org; Thu, 19 Feb 2009 10:00:38 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LaAOC-0001nd-Rl for qemu-devel@nongnu.org; Thu, 19 Feb 2009 10:00:37 -0500 Received: from [199.232.76.173] (port=50556 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LaAOC-0001na-Oq for qemu-devel@nongnu.org; Thu, 19 Feb 2009 10:00:36 -0500 Received: from mx2.redhat.com ([66.187.237.31]:33043) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LaAOC-0003ok-3e for qemu-devel@nongnu.org; Thu, 19 Feb 2009 10:00:36 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n1JF0ZO5012339 for ; Thu, 19 Feb 2009 10:00:35 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n1JF0ZPc006279 for ; Thu, 19 Feb 2009 10:00:36 -0500 Received: from pike.pond.sub.org (vpn-10-63.str.redhat.com [10.32.10.63]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n1JF0XgJ003258 for ; Thu, 19 Feb 2009 10:00:34 -0500 Subject: Re: [Qemu-devel] Machine description as data prototype, take 3 References: <87iqnh6kyv.fsf@pike.pond.sub.org> <871vtuafdr.fsf@pike.pond.sub.org> <499D6E7B.9080306@codemonkey.ws> From: Markus Armbruster Date: Thu, 19 Feb 2009 16:00:33 +0100 In-Reply-To: <499D6E7B.9080306@codemonkey.ws> (Anthony Liguori's message of "Thu\, 19 Feb 2009 08\:36\:43 -0600") Message-ID: <87vdr64gku.fsf@pike.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Anthony Liguori writes: > Markus Armbruster wrote: >> Third iteration of the prototype. >> >> What about an early merge? If your answer to that is "yes, but", what >> exactly do you want changed? >> > > I'm all for an early merge but I think there has to be enough of the > architectural changes in place to allow other people to understand the > long term direction and also contribute. > > I think the following are required for merge: > > 1) introduction of a new machine init function that returns a tree > 2) code outside of dt.c, when -drive if=ide is specified, walks the > tree looking for a node with an IDE decoration. Finds the appropriate > master/slave primary/secondary slot, and hooks up the BlockDriverState > to the IDE device. > 3) reading the machine description from a file > > Basically, enough of the architecture that it's clear that we just > need to do #2 for all of the remaining devices. I don't think your > that far from this today. Okay, I'll attack (1) and (2) next, and then we can talk again. >> New: >> >> * Rebased to git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6626 c046a42c-6fe2-441c-8c8c-71466251a162 >> >> * Code duplication cleaned up. I chose minimizing the impact on pc.c >> over nice, clean interfaces. Happy to rework it if that was the wrong >> choice. I think there are a few opportunities for cleanup that would >> improve pc.c even without taking dt.c into consideration. I can work >> on patches if you like. >> >> * The "device required" edges moved from struct tree to struct dt_device >> to make the configuration tree more similar to FDTs structurally. >> >> * A bunch of pointless typedefs to hopefully blend in better >> stylistically. Tabs expanded. If style issues remain, please point >> them out to me! >> > > I'll respond in a separate note but the style is still off. Appreciated.