From: Fabiano Rosas <farosas@suse.de>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Dario Faggioli" <dfaggioli@suse.com>
Subject: Re: [RFC PATCH] elfload: Fix alignment when unmapping excess reservation
Date: Wed, 19 Feb 2025 10:05:39 -0300 [thread overview]
Message-ID: <87wmdm84po.fsf@suse.de> (raw)
In-Reply-To: <1d9428e2-8e9d-40c4-a7fe-67e1a5965dc9@tls.msk.ru>
Michael Tokarev <mjt@tls.msk.ru> writes:
> 13.02.2025 17:35, Fabiano Rosas wrote:
>> When complying with the alignment requested in the ELF and unmapping
>> the excess reservation, having align_end not aligned to the guest page
>> causes the unmap to be rejected by the alignment check at
>> target_munmap and later brk adjustments hit an EEXIST.
>>
>> Fix by aligning the start of region to be unmapped.
>>
>> Fixes: c81d1fafa6 ("linux-user: Honor elf alignment when placing images")
>> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1913
>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>
> Is this a qemu-stable material? That issue was quite hot..
Yes, I think it's good for stable.
>
> Thanks,
>
> /mjt
prev parent reply other threads:[~2025-02-19 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 14:35 [RFC PATCH] elfload: Fix alignment when unmapping excess reservation Fabiano Rosas
2025-02-15 19:06 ` Richard Henderson
2025-02-15 19:08 ` Richard Henderson
2025-02-19 7:42 ` Michael Tokarev
2025-02-19 13:05 ` Fabiano Rosas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmdm84po.fsf@suse.de \
--to=farosas@suse.de \
--cc=alex.bennee@linaro.org \
--cc=dfaggioli@suse.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).