From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] Revert "cputlb: Restrict SavedIOTLB to system emulation"
Date: Thu, 22 Jun 2023 18:49:26 +0200 [thread overview]
Message-ID: <87wmzvh27d.fsf@linaro.org> (raw)
In-Reply-To: <780c8505-9cd7-87fd-c5cc-23f0e8aa455c@linaro.org>
Hello,
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> On 21/6/23 11:39, Philippe Mathieu-Daudé wrote:
>> On 21/6/23 07:19, Richard Henderson wrote:
>>> On 6/20/23 19:57, Peter Maydell wrote:
>>>> This manifests specifically in 'make check-tcg' failing, because code
>>>> in cpus-common.c that sets up the CPUState::cpu_index field puts it
>>>> at a different offset from the code in plugins/core.c in
>>>> qemu_plugin_vcpu_init_hook() which reads the cpu_index field. The
>>>> latter then hits an assert because from its point of view every
>>>> thread has a 0 cpu_index. There might be other weird behaviour too.
>> Why isn't this covered by CI, and where could we add a such check?
>
> Actually it is covered and failed on staging:
> https://gitlab.com/qemu-project/qemu/-/jobs/4503766933
Just for the record, it was also caught yesterday by the TCWG CI:
https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-bisect/87/
--
Thiago
prev parent reply other threads:[~2023-06-22 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 17:57 [PATCH] Revert "cputlb: Restrict SavedIOTLB to system emulation" Peter Maydell
2023-06-21 5:19 ` Richard Henderson
2023-06-21 9:39 ` Philippe Mathieu-Daudé
2023-06-21 10:57 ` Philippe Mathieu-Daudé
2023-06-22 16:49 ` Thiago Jung Bauermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmzvh27d.fsf@linaro.org \
--to=thiago.bauermann@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).