* [PATCH] include/hw/arm/allwinner-a10.h: Remove superfluous includes from the header
@ 2023-02-15 15:22 Thomas Huth
2023-02-15 17:33 ` Alex Bennée
2023-02-20 14:51 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2023-02-15 15:22 UTC (permalink / raw)
To: qemu-devel, Peter Maydell
Cc: qemu-arm, Beniamino Galvani, Strahinja Jankovic, qemu-trivial
pci_device.h is not needed at all in allwinner-a10.h, and serial.h
is only needed by the corresponding .c file.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
include/hw/arm/allwinner-a10.h | 2 --
hw/arm/allwinner-a10.c | 1 +
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/hw/arm/allwinner-a10.h b/include/hw/arm/allwinner-a10.h
index 79e0c80568..095afb225d 100644
--- a/include/hw/arm/allwinner-a10.h
+++ b/include/hw/arm/allwinner-a10.h
@@ -1,9 +1,7 @@
#ifndef HW_ARM_ALLWINNER_A10_H
#define HW_ARM_ALLWINNER_A10_H
-#include "hw/char/serial.h"
#include "hw/arm/boot.h"
-#include "hw/pci/pci_device.h"
#include "hw/timer/allwinner-a10-pit.h"
#include "hw/intc/allwinner-a10-pic.h"
#include "hw/net/allwinner_emac.h"
diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c
index dc1966ff7a..b7ca795c71 100644
--- a/hw/arm/allwinner-a10.c
+++ b/hw/arm/allwinner-a10.c
@@ -18,6 +18,7 @@
#include "qemu/osdep.h"
#include "qapi/error.h"
#include "qemu/module.h"
+#include "hw/char/serial.h"
#include "hw/sysbus.h"
#include "hw/arm/allwinner-a10.h"
#include "hw/misc/unimp.h"
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] include/hw/arm/allwinner-a10.h: Remove superfluous includes from the header
2023-02-15 15:22 [PATCH] include/hw/arm/allwinner-a10.h: Remove superfluous includes from the header Thomas Huth
@ 2023-02-15 17:33 ` Alex Bennée
2023-02-20 14:51 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2023-02-15 17:33 UTC (permalink / raw)
To: Thomas Huth
Cc: Peter Maydell, qemu-arm, Beniamino Galvani, Strahinja Jankovic,
qemu-trivial, qemu-devel
Thomas Huth <thuth@redhat.com> writes:
> pci_device.h is not needed at all in allwinner-a10.h, and serial.h
> is only needed by the corresponding .c file.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] include/hw/arm/allwinner-a10.h: Remove superfluous includes from the header
2023-02-15 15:22 [PATCH] include/hw/arm/allwinner-a10.h: Remove superfluous includes from the header Thomas Huth
2023-02-15 17:33 ` Alex Bennée
@ 2023-02-20 14:51 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2023-02-20 14:51 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, qemu-arm, Beniamino Galvani, Strahinja Jankovic,
qemu-trivial
On Wed, 15 Feb 2023 at 15:22, Thomas Huth <thuth@redhat.com> wrote:
>
> pci_device.h is not needed at all in allwinner-a10.h, and serial.h
> is only needed by the corresponding .c file.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> include/hw/arm/allwinner-a10.h | 2 --
> hw/arm/allwinner-a10.c | 1 +
> 2 files changed, 1 insertion(+), 2 deletions(-)
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-20 14:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-15 15:22 [PATCH] include/hw/arm/allwinner-a10.h: Remove superfluous includes from the header Thomas Huth
2023-02-15 17:33 ` Alex Bennée
2023-02-20 14:51 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).