From: "Alex Bennée" <alex.bennee@linaro.org>
To: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
Cc: Alistair Francis <alistair23@gmail.com>,
qemu-riscv@nongnu.org, Alistair.Francis@wdc.com,
palmer@dabbelt.com, bin.meng@windriver.com,
sergey.matyukevich@syntacore.com, vladimir.isaev@syntacore.com,
anatoly.parshintsev@syntacore.com, philipp.tomsich@vrull.eu,
zhiwei_liu@c-sky.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v1 1/4] target/riscv: Add itrigger support when icount is not enabled
Date: Mon, 07 Nov 2022 15:58:26 +0000 [thread overview]
Message-ID: <87wn86g3i2.fsf@linaro.org> (raw)
In-Reply-To: <ebdbec47-9dbe-e1a2-5033-9421710debb6@linux.alibaba.com>
LIU Zhiwei <zhiwei_liu@linux.alibaba.com> writes:
> On 2022/11/7 9:37, Alistair Francis wrote:
>> On Thu, Oct 13, 2022 at 4:32 PM LIU Zhiwei <zhiwei_liu@linux.alibaba.com> wrote:
>>> When icount is not enabled, there is no API in QEMU that can get the
>>> guest instruction number.
>>>
>>> Translate the guest code in a way that each TB only has one instruction.
>> I don't think this is a great idea.
>>
>> Why can't we just require icount be enabled if a user wants this? Or singlestep?
>
> This feature will only be used by users who want to run the native
> gdb on Linux. If we run QEMU as a service, after booting the kernel,
> we can't predicate whether the users will use native gdb.
>
> Besides, icount can't be enabled on MTTCG currently (I am working on
> this problem)
I'm curious as to what your approach is going to be to solve this one?
--
Alex Bennée
next prev parent reply other threads:[~2022-11-07 15:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 6:29 [PATCH v1 0/4] Support native debug icount trigger LIU Zhiwei
2022-10-13 6:29 ` [PATCH v1 1/4] target/riscv: Add itrigger support when icount is not enabled LIU Zhiwei
2022-11-07 1:37 ` Alistair Francis
2022-11-07 2:01 ` LIU Zhiwei
2022-11-07 15:58 ` Alex Bennée [this message]
2022-11-08 1:54 ` LIU Zhiwei
2022-11-09 22:33 ` Alistair Francis
2022-10-13 6:29 ` [PATCH v1 2/4] target/riscv: Add itrigger support when icount is enabled LIU Zhiwei
2022-11-09 22:50 ` Alistair Francis
2022-10-13 6:29 ` [PATCH v1 3/4] target/riscv: Enable native debug itrigger LIU Zhiwei
2022-11-09 22:54 ` Alistair Francis
2022-10-13 6:29 ` [PATCH v1 4/4] target/riscv: Add itrigger_enabled field to CPURISCVState LIU Zhiwei
2022-11-09 22:55 ` Alistair Francis
2022-11-10 2:15 ` LIU Zhiwei
2022-11-10 5:35 ` Richard Henderson
2022-11-11 0:54 ` Alistair Francis
2022-11-11 5:31 ` [PATCH v1 0/4] Support native debug icount trigger Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn86g3i2.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=Alistair.Francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=anatoly.parshintsev@syntacore.com \
--cc=bin.meng@windriver.com \
--cc=palmer@dabbelt.com \
--cc=philipp.tomsich@vrull.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sergey.matyukevich@syntacore.com \
--cc=vladimir.isaev@syntacore.com \
--cc=zhiwei_liu@c-sky.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).