qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Sven Schnelle <svens@stackframe.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: deller@gmx.de,  qemu-devel@nongnu.org
Subject: Re: [PATCH 0/3] artist: minor fixes and performance improvement
Date: Fri, 06 May 2022 10:45:41 +0200	[thread overview]
Message-ID: <87wnez9hhm.fsf@x1.stackframe.org> (raw)
In-Reply-To: <20220504153708.10352-1-mark.cave-ayland@ilande.co.uk> (Mark Cave-Ayland's message of "Wed, 4 May 2022 16:37:05 +0100")

Hi Mark,

Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> writes:

> Patch 1 updates artist.c to fix some style issues and ensure that artist.c passes
> checkpatch for the remainder of the patchset, whilst patch 2 removes the ROP8OFF()
> macro which is currently unused.
>
> Finally patch 3 is the main reason for this patchset and improves the performance
> of the artist framebuffer by only rendering the dirty scanlines to the display
> surface, which noticeably improves boot times and makes the GTK UI usable on my
> fairly modest laptop.
>
> [Helge/Sven: if you can provide a Tested-by or Reviewed-by tag for this patchset
> before the weekend, I can include it in my PR containing all the other HPPA
> updates]
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>
>
> Mark Cave-Ayland (3):
>   artist: checkpatch and newline style fixes
>   artist: remove unused ROP8OFF() macro
>   artist: only render dirty scanlines on the display surface
>
>  hw/display/artist.c | 33 ++++++++++++++-------------------
>  1 file changed, 14 insertions(+), 19 deletions(-)

I reviewed and tested the patches with HP-UX 10.20 and HP-UX 11.11. Feel
free to add my

Reviewed-by: Sven Schnelle <svens@stackframe.org>


      parent reply	other threads:[~2022-05-06 14:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-04 15:37 [PATCH 0/3] artist: minor fixes and performance improvement Mark Cave-Ayland
2022-05-04 15:37 ` [PATCH 1/3] artist: checkpatch and newline style fixes Mark Cave-Ayland
2022-05-04 15:43   ` Peter Maydell
2022-05-04 15:37 ` [PATCH 2/3] artist: remove unused ROP8OFF() macro Mark Cave-Ayland
2022-05-04 15:42   ` Peter Maydell
2022-05-04 15:37 ` [PATCH 3/3] artist: only render dirty scanlines on the display surface Mark Cave-Ayland
2022-05-05 12:26 ` [PATCH 0/3] artist: minor fixes and performance improvement Helge Deller
2022-05-08  9:26   ` Mark Cave-Ayland
2022-05-06  8:45 ` Sven Schnelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnez9hhm.fsf@x1.stackframe.org \
    --to=svens@stackframe.org \
    --cc=deller@gmx.de \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).