From: Cornelia Huck <cohuck@redhat.com>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>, eric.auger@redhat.com
Cc: lvivier@redhat.com,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
thuth@redhat.com, mst@redhat.com, qemu-devel@nongnu.org,
pasic@linux.ibm.com, pbonzini@redhat.com
Subject: Re: [PATCH v2 2/4] virtio-iommu: Default to bypass during boot
Date: Tue, 08 Feb 2022 18:42:57 +0100 [thread overview]
Message-ID: <87wni5tftq.fsf@redhat.com> (raw)
In-Reply-To: <20220127142940.671333-3-jean-philippe@linaro.org>
On Thu, Jan 27 2022, Jean-Philippe Brucker <jean-philippe@linaro.org> wrote:
> @@ -988,9 +1025,9 @@ static void virtio_iommu_device_realize(DeviceState *dev, Error **errp)
> virtio_add_feature(&s->features, VIRTIO_IOMMU_F_INPUT_RANGE);
> virtio_add_feature(&s->features, VIRTIO_IOMMU_F_DOMAIN_RANGE);
> virtio_add_feature(&s->features, VIRTIO_IOMMU_F_MAP_UNMAP);
> - virtio_add_feature(&s->features, VIRTIO_IOMMU_F_BYPASS);
> virtio_add_feature(&s->features, VIRTIO_IOMMU_F_MMIO);
> virtio_add_feature(&s->features, VIRTIO_IOMMU_F_PROBE);
> + virtio_add_feature(&s->features, VIRTIO_IOMMU_F_BYPASS_CONFIG);
Hm. In the other patch, you say that you don't support cross-version
migration (I assume across QEMU versions?) Because changing the feature
set will be guest-visible, and would need some compat handling if you
plan to support this.
next prev parent reply other threads:[~2022-02-08 19:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 14:29 [PATCH v2 0/4] virtio-iommu: Support VIRTIO_IOMMU_F_BYPASS_CONFIG Jean-Philippe Brucker
2022-01-27 14:29 ` [PATCH v2 1/4] linux-headers: update to v5.17-rc1 Jean-Philippe Brucker
2022-01-31 9:14 ` Eric Auger
2022-01-27 14:29 ` [PATCH v2 2/4] virtio-iommu: Default to bypass during boot Jean-Philippe Brucker
2022-01-31 9:14 ` Eric Auger
2022-02-08 17:42 ` Cornelia Huck [this message]
2022-02-08 21:07 ` Michael S. Tsirkin
2022-02-09 11:10 ` Cornelia Huck
2022-02-09 11:32 ` Eric Auger
2022-02-09 12:48 ` Cornelia Huck
2022-01-27 14:29 ` [PATCH v2 3/4] virtio-iommu: Support bypass domain Jean-Philippe Brucker
2022-01-31 9:22 ` Eric Auger
2022-01-31 13:07 ` Dr. David Alan Gilbert
2022-02-02 13:21 ` Eric Auger
2022-02-08 12:30 ` Jean-Philippe Brucker
2022-02-08 13:09 ` Dr. David Alan Gilbert
2022-02-08 13:29 ` Eric Auger
2022-02-08 17:02 ` Jean-Philippe Brucker
2022-01-27 14:29 ` [PATCH v2 4/4] tests/qtest/virtio-iommu-test: Check bypass config Jean-Philippe Brucker
2022-01-31 9:14 ` Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wni5tftq.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).