From: "Alex Bennée" <alex.bennee@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: stratos-dev@op-lists.linaro.org,
Vincent Guittot <vincent.guittot@linaro.org>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 1/2] hw/virtio: add boilerplate for vhost-user-gpio device
Date: Mon, 17 Jan 2022 10:17:41 +0000 [thread overview]
Message-ID: <87wniyacmu.fsf@linaro.org> (raw)
In-Reply-To: <20220117063840.lyg24ikcavis645b@vireshk-i7>
Viresh Kumar <viresh.kumar@linaro.org> writes:
> On 14-01-22, 14:06, Alex Bennée wrote:
>>
>> Viresh Kumar <viresh.kumar@linaro.org> writes:
>>
>> > This creates the QEMU side of the vhost-user-gpio device which connects
>> > to the remote daemon. It is based of vhost-user-i2c code.
>> >
>> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>> <snip>
>> > +++ b/include/hw/virtio/vhost-user-gpio.h
>> > @@ -0,0 +1,35 @@
>> > +/*
>> > + * Vhost-user GPIO virtio device
>> > + *
>> > + * Copyright (c) 2021 Viresh Kumar <viresh.kumar@linaro.org>
>> > + *
>> > + * SPDX-License-Identifier: GPL-2.0-or-later
>> > + */
>> > +
>> > +#ifndef _QEMU_VHOST_USER_GPIO_H
>> > +#define _QEMU_VHOST_USER_GPIO_H
>> > +
>> > +#include "hw/virtio/virtio.h"
>> > +#include "hw/virtio/vhost.h"
>> > +#include "hw/virtio/vhost-user.h"
>> > +#include "standard-headers/linux/virtio_gpio.h"
>>
>> Hmm this fails:
>>
>> In file included from ../../hw/virtio/vhost-user-gpio.c:13:
>> /home/alex/lsrc/qemu.git/include/hw/virtio/vhost-user-gpio.h:15:10: fatal error: standard-headers/linux/virtio_gpio.h: No such file or directory
>> 15 | #include "standard-headers/linux/virtio_gpio.h"
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> compilation terminated.
>>
>> The usual solution is to create a patch that imports the headers using:
>>
>> ./scripts/update-linux-headers.sh
>>
>> either from the current mainline (or your own tree if the feature is in
>> flight) and mark the patch clearly as not for merging.
>
> I have that patch with me and I planned to mention it in the cover-letter, but
> completely failed while sending it.
>
> Should I resend this with the NOT-TO-BE-APPLIED patch now ? Everything is in
> mainline, so the committer just needs to run
> scripts/update-linux-headers.sh.
If it's a released version of mainline even better because you can just
include the patch generated from a clean release and it can get merged.
--
Alex Bennée
next prev parent reply other threads:[~2022-01-17 10:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 11:34 [PATCH 0/2] virtio: Add vhost-user-gpio device's support Viresh Kumar
2022-01-12 11:34 ` [PATCH 1/2] hw/virtio: add boilerplate for vhost-user-gpio device Viresh Kumar
2022-01-14 14:05 ` Alex Bennée
2022-01-14 14:06 ` Alex Bennée
2022-01-17 6:38 ` Viresh Kumar
2022-01-17 10:17 ` Alex Bennée [this message]
2022-01-12 11:34 ` [PATCH 2/2] hw/virtio: add vhost-user-gpio-pci boilerplate Viresh Kumar
2022-01-14 14:10 ` Alex Bennée
2022-01-17 8:47 ` [PATCH 0/2] virtio: Add vhost-user-gpio device's support Michael S. Tsirkin
2022-01-17 10:11 ` Alex Bennée
2022-01-20 4:02 ` Viresh Kumar
2022-01-20 10:57 ` Michael S. Tsirkin
2022-01-20 15:41 ` Alex Bennée
2022-01-21 15:15 ` [RFC PATCH] tests/qtest: attempt to enable tests for virtio-gpio (!working) Alex Bennée
2022-03-31 9:52 ` Alex Bennée
2022-03-31 16:17 ` Stefan Hajnoczi
2022-04-04 17:59 ` Dr. David Alan Gilbert
2022-04-05 13:46 ` Alex Bennée
2022-01-20 11:25 ` [PATCH 0/2] virtio: Add vhost-user-gpio device's support Michael S. Tsirkin
2022-02-04 12:23 ` Michael S. Tsirkin
2022-02-04 13:52 ` Alex Bennée
2022-02-04 14:06 ` Michael S. Tsirkin
2022-03-31 9:58 ` Alex Bennée
2022-04-05 10:55 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wniyacmu.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stratos-dev@op-lists.linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).