From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C79DC433E0 for ; Wed, 22 Jul 2020 11:34:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45F2520729 for ; Wed, 22 Jul 2020 11:34:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="B0SwZKcJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45F2520729 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59198 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jyD1H-0001Kl-JE for qemu-devel@archiver.kernel.org; Wed, 22 Jul 2020 07:34:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyD0T-0000t6-3j for qemu-devel@nongnu.org; Wed, 22 Jul 2020 07:33:53 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:34007) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jyD0R-0001IZ-KB for qemu-devel@nongnu.org; Wed, 22 Jul 2020 07:33:52 -0400 Received: by mail-wr1-x443.google.com with SMTP id f7so1577929wrw.1 for ; Wed, 22 Jul 2020 04:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=ZV+axtv27r3oylfG9HfBY97Mh/qY3164XPVKKSWPOFI=; b=B0SwZKcJwsV7fF6UpvHNpA8VfdK8/0VmhuJ8bg/PZijBd1+eqfUVSkK0CmftzZl7xm jXraEzf0efyf5IzriMJQMN9kgerkjeL11lhfrutOq48Pi3R2H4rhoPgjNK3F3SCBD7Si 1k1Zav6EMRVz5Oe9LwePVYnu9dlzw/fGFkYLi5h8IoLLc0iPDx1Qu9A05JBf9KKQYG35 1jz/flFYMBQQaJBUlM5sEqKkCLAXmoWPpLrSQFHg3oDQuu9Fke7aPkzBvVRjM/Xku0tO hsKX0nxs+VbwNXd9YDcrdgq3Lv9rb4ypbr/DFMCvZ5KICE0BdOho4KJvBPFLvOv/+bqi lLZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=ZV+axtv27r3oylfG9HfBY97Mh/qY3164XPVKKSWPOFI=; b=ca7garAWaeBUl4xAITLLV+RbwJZBoNd8JdEc+xXF97DkphtRP0kBsdVV0u4BGmV9pQ YFbYY1NucGIsZpgSljumL3smmT2p+K/U3PK217HY+syojvboP0r/EPkC5b05qJf/Bq+Q KqpFMitoALCJvcQFtn2f2HBtdB/Jw5TfFF/jBDGMjCd+glexari150YZkfkBe5fETdIK RfXmGn0ilawAtMty0puYKyfDwDzLMDsCmO5n3hlQnfRGXkzRdEFf+YPh+z7pTochO5b2 uvdTY/Nx/ABfD+bJWpwT0+mA6TKEQgtwNfRK6TYS6KS+wi3vvbiSiRGq0TCgZUPQ/EJ0 /3/Q== X-Gm-Message-State: AOAM533PEjnbuEz57E05e8vGcZ0jFZiMJ8b761yxhGObDt1RNNQyYgrb bD+LVd8N2xKXGjSWSrngBojIZw== X-Google-Smtp-Source: ABdhPJznTM9oXQS+qhM0HU/sHBStrjw/FNqJ/ioHnk4YAfKJzpRBAIGAL509iBFcDFMmU0JKirMOAg== X-Received: by 2002:a5d:6748:: with SMTP id l8mr4912987wrw.358.1595417629872; Wed, 22 Jul 2020 04:33:49 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id m128sm6573832wmf.37.2020.07.22.04.33.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2020 04:33:48 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 8F8A21FF7E; Wed, 22 Jul 2020 12:33:47 +0100 (BST) References: <20200722062902.24509-1-alex.bennee@linaro.org> <20200722062902.24509-6-alex.bennee@linaro.org> <6d316f94-fd8a-9b59-5f47-f37c833eb79b@weilnetz.de> User-agent: mu4e 1.5.5; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Stefan Weil Subject: Re: [PATCH v2 05/12] util/oslib-win32: add qemu_get_host_physmem implementation In-reply-to: <6d316f94-fd8a-9b59-5f47-f37c833eb79b@weilnetz.de> Date: Wed, 22 Jul 2020 12:33:47 +0100 Message-ID: <87wo2vu6lg.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::443; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x443.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, f4bug@amsat.org, cota@braap.org, aurelien@aurel32.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Stefan Weil writes: > Am 22.07.20 um 08:28 schrieb Alex Benn=C3=A9e: > >> It seems GetPhysicallyInstalledSystemMemory isn't available in the >> MinGW headers so we have to declare it ourselves. Compile tested only. > > > It is available, at least for Mingw-w64 which I also use for cross > builds on Debian, but is only included with _WIN32_WINNT >=3D 0x0601. > > Currently we set _WIN32_WINNT to 0x0600. That would explain why some people see things working if they build with visual studio (which I presume has a higher setting). We could just wrap the body of the function in: #if (_WIN32_WINNT >=3D 0x0601) much like in commands-win32.c? Of course it wouldn't even be compile tested (I used the fedora docker image). We should probably clean up the test-mingw code to work with both the fedora and debian-w[32|64] images. > > Regards, > > Stefan --=20 Alex Benn=C3=A9e