qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Fred Konrad <konrad@adacore.com>
Cc: "QEMU Trivial" <qemu-trivial@nongnu.org>,
	frederic.konrad@adacore.com,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH] semihosting: remove the pthread include which seems unused
Date: Mon, 01 Jun 2020 11:29:26 +0100	[thread overview]
Message-ID: <87wo4r6pvd.fsf@linaro.org> (raw)
In-Reply-To: <dfd77414-83e8-755f-1386-13188b968aef@adacore.com>


Fred Konrad <konrad@adacore.com> writes:

> Le 5/18/20 à 3:50 PM, Philippe Mathieu-Daudé a écrit :
>> On 5/18/20 3:02 PM, konrad@adacore.com wrote:
>>> From: KONRAD Frederic <frederic.konrad@adacore.com>
>>>
>>> This have been introduced by:
>>>    8de702cb677c8381fb702cae252d6b69aa4c653b
>>>
>>> It doesn't seem to be used so remove it.
>>>
>>> Signed-off-by: KONRAD Frederic <frederic.konrad@adacore.com>
>>> ---
>>>   hw/semihosting/console.c | 1 -
>>>   1 file changed, 1 deletion(-)
>>>
>>> diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c
>>> index 6346bd7..22e7827 100644
>>> --- a/hw/semihosting/console.c
>>> +++ b/hw/semihosting/console.c
>>> @@ -23,7 +23,6 @@
>>>   #include "exec/exec-all.h"
>>>   #include "qemu/log.h"
>>>   #include "chardev/char.h"
>>> -#include <pthread.h>
>>>   #include "chardev/char-fe.h"
>>>   #include "sysemu/sysemu.h"
>>>   #include "qemu/main-loop.h"
>>>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> 
>
> Thanks for the review, Philippe.  Can this go through qemu-trivial?

Sure:

Acked-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée


      reply	other threads:[~2020-06-01 10:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-18 13:02 [PATCH] semihosting: remove the pthread include which seems unused konrad
2020-05-18 13:50 ` Philippe Mathieu-Daudé
2020-06-01  9:19   ` Fred Konrad
2020-06-01 10:29     ` Alex Bennée [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wo4r6pvd.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=frederic.konrad@adacore.com \
    --cc=konrad@adacore.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).