qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw/arm: set machine 'virt' as default
Date: Wed, 18 Sep 2019 21:33:57 +0100	[thread overview]
Message-ID: <87woe5z6mi.fsf@linaro.org> (raw)
In-Reply-To: <20190917172422.5134-1-dan.streetman@canonical.com>


Dan Streetman <dan.streetman@canonical.com> writes:

> From: Dan Streetman <ddstreet@canonical.com>
>
> There is currently no default machine type for arm so one must be specified
> with --machine.  This sets the 'virt' machine type as default.

We should really have a FAQ entry for why we don't have a default for
ARM. In short unlike PC's every ARM device is different so it pays to be
precise about what you want when you invoke QEMU. Because any given
kernel/image is only likely to work on the machine it's built for.

Why is virt special? It's just one of the many machines we emulate and
while it's probably the most popular these days for "something that
boots a Linux distro" why not -machine sba (when that comes)?

>
> Signed-off-by: Dan Streetman <ddstreet@canonical.com>
> ---
>  hw/arm/virt.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index d74538b021..e9fe888ca2 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -78,6 +78,7 @@
>          mc->desc = "QEMU " # major "." # minor " ARM Virtual Machine"; \
>          if (latest) { \
>              mc->alias = "virt"; \
> +            mc->is_default = 1; \
>          } \
>      } \
>      static const TypeInfo machvirt_##major##_##minor##_info = { \


--
Alex Bennée


  parent reply	other threads:[~2019-09-18 20:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-17 17:24 [Qemu-devel] [PATCH] hw/arm: set machine 'virt' as default Dan Streetman
2019-09-17 17:36 ` Dan Streetman
2019-09-18 20:33 ` Alex Bennée [this message]
2019-09-18 21:56   ` Dan Streetman
2019-09-19  9:34     ` Philippe Mathieu-Daudé
2019-10-15 16:31       ` Dan Streetman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87woe5z6mi.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).