Re: [Qemu-devel] [PATCH v3 09/20] linux-user: introduce preexit_cleanup

["Alex Bennée" <alex.bennee@linaro.org>]

Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> On 07/02/2018 01:22 PM, Philippe Mathieu-Daudé wrote:
>> Using:
>>
>> 'configure' '--enable-gprof' '--enable-gcov' '--disable-pie' --static
>> [...]
>> C compiler        gcc-8
>> CFLAGS            -fprofile-arcs -ftest-coverage -g -g
>> LDFLAGS           -Wl,--warn-common -fprofile-arcs -ftest-coverage -m64
>> -static -g
>> gprof enabled     yes
>> static build      yes
>> PIE               no
>> gcov              gcov
>> gcov enabled      yes
>> docker            yes
>>
>> I get:
>>
>> $ make subdir-ppc-linux-user
>> [...]
>>   CC      ppc-linux-user/linux-user/exit.o
>> linux-user/exit.c: In function ‘preexit_cleanup’:
>> linux-user/exit.c:29:9: error: implicit declaration of function
>> ‘_mcleanup’ [-Werror=implicit-function-declaration]
>>          _mcleanup();
>>          ^~~~~~~~~
>> linux-user/exit.c:29:9: error: nested extern declaration of ‘_mcleanup’
>> [-Werror=nested-externs]
>> cc1: all warnings being treated as errors
>> make[1]: *** [rules.mak:69: linux-user/exit.o] Error 1
>> make: *** [Makefile:481: subdir-ppc-linux-user] Error 2
>>
>> I suppose gprof and static builds are exclusive.

Yeah I guess this must have always been there because I didn't change
the gprof code, just moved it.

>
> I just noticed we don't have --static builds covered by our continuous
> integration.
> Yet too many matrix cases to cover?
> We could ignore it for 'system' builds, but we should enable it for
> --linux-user which is used by various distributions for with the binfmt
> packages.

Yeah certainly a --disable-system --static build makes sense.

>
> Regards,
>
> Phil.


--
Alex Bennée