From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCo2Z-0008Nb-99 for qemu-devel@nongnu.org; Mon, 22 May 2017 10:10:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCo2V-0002wx-UP for qemu-devel@nongnu.org; Mon, 22 May 2017 10:10:31 -0400 Received: from mail-wr0-x22d.google.com ([2a00:1450:400c:c0c::22d]:33238) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dCo2V-0002wf-OQ for qemu-devel@nongnu.org; Mon, 22 May 2017 10:10:27 -0400 Received: by mail-wr0-x22d.google.com with SMTP id w50so39425287wrc.0 for ; Mon, 22 May 2017 07:10:27 -0700 (PDT) References: <20170521032956.27446-1-f4bug@amsat.org> <20170521032956.27446-19-f4bug@amsat.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <20170521032956.27446-19-f4bug@amsat.org> Date: Mon, 22 May 2017 15:10:30 +0100 Message-ID: <87wp992d9l.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v3 18/24] shippable: do not initialize submodules automatically List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Fam Zheng , Aurelien Jarno , Riku Voipio , Vagrant Cascadian , Michael Tokarev Philippe Mathieu-Daudé writes: > instead do it in the 'ci' target when needed. > > for mips64el-softmmu target: > use dtc submodule if distrib packages are too old. > > example with outdated libfdt on mips64el-softmmu target (required is >= 1.4.2): > # dpkg-query --showformat='${Version}\n' --show libfdt-dev > 1.4.0+dfsg-1 > > shippable output: > ---------------- > LINK mips64el-softmmu/qemu-system-mips64el > ../hw/core/loader-fit.o: In function `load_fit': > /root/src/github.com/philmd/qemu/hw/core/loader-fit.c:278: undefined reference to `fdt_first_subnode' > /root/src/github.com/philmd/qemu/hw/core/loader-fit.c:286: undefined reference to `fdt_next_subnode' > /root/src/github.com/philmd/qemu/hw/core/loader-fit.c:277: undefined reference to `fdt_first_subnode' > collect2: error: ld returned 1 exit status > Makefile:201: recipe for target 'qemu-system-mips64el' failed > make[1]: *** [qemu-system-mips64el] Error 1 > Makefile:327: recipe for target 'subdir-mips64el-softmmu' failed > make: *** [subdir-mips64el-softmmu] Error 2 > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > .shippable.yml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/.shippable.yml b/.shippable.yml > index 1e3ae35dd9..46adfa030f 100644 > --- a/.shippable.yml > +++ b/.shippable.yml > @@ -1,4 +1,6 @@ > language: c > +git: > + submodules: false > env: > global: > - LC_ALL=C > @@ -19,5 +21,13 @@ build: > options: "-e HOME=/root" > ci: > - unset CC > + # some targets require newer up to date packages, for example TARGET_LIST matching > + # aarch64*-softmmu|arm*-softmmu|ppc*-softmmu|microblaze*-softmmu|mips64el-softmmu) > + # see the configure script: > + # error_exit "DTC (libfdt) version >= 1.4.2 not present. Your options:" > + # " (1) Preferred: Install the DTC (libfdt) devel package" > + # " (2) Fetch the DTC submodule, using:" > + # " git submodule update --init dtc" > + - dpkg --compare-versions `dpkg-query --showformat='${Version}' --show libfdt-dev` ge 1.4.2 || git submodule update --init dtc > - ./configure ${QEMU_CONFIGURE_OPTS} --target-list=${TARGET_LIST} > - make -j$(($(getconf _NPROCESSORS_ONLN) + 1)) -- Alex Bennée