From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55623)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1cvqZz-0005H0-SS
	for qemu-devel@nongnu.org; Wed, 05 Apr 2017 15:26:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1cvqZv-000388-UQ
	for qemu-devel@nongnu.org; Wed, 05 Apr 2017 15:26:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:14612)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <quintela@redhat.com>) id 1cvqZv-00034n-OM
	for qemu-devel@nongnu.org; Wed, 05 Apr 2017 15:26:51 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <20170405190024.27581-3-dgilbert@redhat.com> (David Alan
	Gilbert's message of "Wed, 5 Apr 2017 20:00:23 +0100")
References: <20170405190024.27581-1-dgilbert@redhat.com>
	<20170405190024.27581-3-dgilbert@redhat.com>
Reply-To: quintela@redhat.com
Date: Wed, 05 Apr 2017 21:26:46 +0200
Message-ID: <87wpay3bbd.fsf@secure.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 2/3] vmstatification: i386 FPReg
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com

"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Convert the fpreg save/restore to use VMSTATE_ macros rather than
> .get/.put.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

But if you have to respin

> +typedef struct x86_FPReg_tmp {
> +    FPReg *parent;
> +    uint64_t tmp_mant;
> +    uint16_t tmp_exp;
> +} x86_FPReg_tmp;

Too many tmp's?  I am pretty sure that you can call the fields mant and exp.

Later, Juan.