From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2IAp-0006eb-H6 for qemu-devel@nongnu.org; Thu, 03 Nov 2016 09:35:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2IAl-0004uP-J2 for qemu-devel@nongnu.org; Thu, 03 Nov 2016 09:35:19 -0400 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:36622) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c2IAl-0004tk-4x for qemu-devel@nongnu.org; Thu, 03 Nov 2016 09:35:15 -0400 Received: by mail-wm0-x230.google.com with SMTP id p190so333904491wmp.1 for ; Thu, 03 Nov 2016 06:35:15 -0700 (PDT) References: <20160917140349.12431-1-bobby.prani@gmail.com> <87oa3j7uh0.fsf@gmail.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: Date: Thu, 03 Nov 2016 13:35:12 +0000 Message-ID: <87wpgku1nz.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v3 0/6] Clean up TCG tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: Pranith Kumar , qemu-devel@nongnu.org, rth@twiddle.net Marc-André Lureau writes: > Hi > > On Mon, Sep 19, 2016 at 7:57 PM Pranith Kumar wrote: > >> >> Hi Marc, >> >> Marc-André Lureau writes: >> >> > Hi Pranith >> > >> > On Sat, Sep 17, 2016 at 6:05 PM Pranith Kumar >> wrote: >> > >> >> Hello, >> >> >> >> This patch series cleans up the tcg tests in tests/tcg folder. >> >> >> >> >> > Incidentally, I was also looking at reorganizing tests/tcg last week. I >> > think your series brings some necessary improvements, but it will >> probably >> > need more iterations before it is accepted. Could you split off your >> > obvious changes, such as test build fixes? I think it would help to get >> > those out of the way first (cc -trivial). Also it would help if you >> > documented the makefile changes. >> >> > fwiw, here is my wip at cleaning up tests/tcg: > https://github.com/elmarco/qemu/tree/tcg-tests/tests/tcg > > The build-sys there has a lot of benefits over what is in tests/tcg today: > - uses implicit rules, for building, for running qemu > - dependency tracking > - generate gitignore, clean rule > - detects cross-compiler and qemu, skip the test when unavailable > > I have quite a lot of trouble finding suitable cross-compilers for the > various archs. crosstool-ng helped me to build some of them, but it's not > obvious how to build the various archs, and when it builds, it often > fails/crash. Anyway, this can hopefully give some ideas/inspiration. I did > port i386/x64 and arm, and fixes a couple of qemu bugs on the way. (but arm > mmap test still crashes qemu for ex). > > OK, I will split up the patches into trivial fixes and document the changes >> to >> Makefiles. Where did we get to with these changes? Who's posting the next series? -- Alex Bennée