From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJF58-0001NY-9r for qemu-devel@nongnu.org; Sat, 02 Jul 2016 03:11:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bJF53-0007EC-2X for qemu-devel@nongnu.org; Sat, 02 Jul 2016 03:11:13 -0400 Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:37355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJF52-0007Ds-Ry for qemu-devel@nongnu.org; Sat, 02 Jul 2016 03:11:08 -0400 Received: by mail-wm0-x236.google.com with SMTP id a66so53883581wme.0 for ; Sat, 02 Jul 2016 00:11:08 -0700 (PDT) References: <1464986428-6739-1-git-send-email-alex.bennee@linaro.org> <1464986428-6739-12-git-send-email-alex.bennee@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: Date: Sat, 02 Jul 2016 08:11:13 +0100 Message-ID: <87wpl4ikfi.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC v3 11/19] tcg: add options for enabling MTTCG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: mttcg@greensocs.com, qemu-devel@nongnu.org, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, serge.fdrv@gmail.com, cota@braap.org, bobby.prani@gmail.com, mark.burton@greensocs.com, pbonzini@redhat.com, jan.kiszka@siemens.com, peter.maydell@linaro.org, claudio.fontana@huawei.com, Peter Crosthwaite Richard Henderson writes: > On 06/03/2016 01:40 PM, Alex Bennée wrote: >> +bool qemu_tcg_mttcg_enabled(void) >> +{ >> + return mttcg_enabled; >> +} > > Is there a good reason to expose this via function call, rather than just test > the variable? It was in Fred's original patch. I guess there could be an argument versus a global variable but as mttcg_enabled is set during option parsing we don't need to do anything dynamic. > > > r~ -- Alex Bennée