From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Peter Crosthwaite <crosthwaitepeter@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v4 11/11] cputlb: modernise the debug support
Date: Thu, 04 Feb 2016 07:03:33 +0000 [thread overview]
Message-ID: <87wpqlneii.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA-+gzYE3ys6ybmYP0-0j6gd9RgE6amm4=dkjwgZ6rhj1A@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On 3 February 2016 at 18:54, Alex Bennée <alex.bennee@linaro.org> wrote:
>> It preserves the old behaviour (and the general behaviour of DEBUG_FOO
>> going to stderr). However I'm happy to make it default to using the log
>> output.
>>
>> It does raise the question of if we should just enable the debugging by
>> default?
>
> Not without thinking carefully about it. This is programmer
> debug code for figuring out what's happening in a performance
> sensitive bit of code. "Just print to stderr" is the classic
> way to do this, and I don't think we should just convert that
> into userfacing trace.
Shall I just go back to the original fprintf output then? I made the
output optional a few review comments back.
>
> There may be useful user facing trace we can do of TLB
> operations but I wouldn't assume that our current debug
> printfs are it.
>
> thanks
> -- PMM
--
Alex Bennée
next prev parent reply other threads:[~2016-02-04 7:03 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 9:14 [Qemu-devel] [PATCH v4 00/11] qemu-log, perfmap and other logging tweaks Alex Bennée
2015-08-03 9:14 ` [Qemu-devel] [PATCH v4 01/11] tcg: add ability to dump /tmp/perf-<pid>.map files Alex Bennée
2015-08-03 13:40 ` Paolo Bonzini
2015-08-04 7:39 ` Alex Bennée
2015-08-04 10:02 ` Paolo Bonzini
2015-08-04 11:59 ` Aurelien Jarno
2015-08-04 12:55 ` Alex Bennée
2015-08-04 19:01 ` Aurelien Jarno
2015-08-04 12:15 ` Aurelien Jarno
2015-08-03 9:14 ` [Qemu-devel] [PATCH v4 02/11] tcg: light re-factor and pass down TranslationBlock Alex Bennée
2015-08-04 12:36 ` Aurelien Jarno
2016-02-03 18:38 ` Alex Bennée
2015-08-03 9:14 ` [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu Alex Bennée
2015-08-04 12:16 ` Aurelien Jarno
2015-08-04 15:11 ` Alex Bennée
2015-08-04 15:15 ` Peter Maydell
2015-08-04 15:21 ` Richard Henderson
2015-08-04 17:22 ` Alex Bennée
2015-08-04 18:09 ` Richard Henderson
2015-08-04 19:08 ` Alex Bennée
2015-08-04 19:16 ` Richard Henderson
2015-09-15 19:28 ` Peter Maydell
2015-09-15 19:41 ` Richard Henderson
2015-08-03 9:14 ` [Qemu-devel] [PATCH v4 04/11] qemu-log: Avoid function call for disabled qemu_log_mask logging Alex Bennée
2015-08-04 12:17 ` Aurelien Jarno
2015-08-03 9:14 ` [Qemu-devel] [PATCH v4 05/11] qemu-log: Improve the "exec" TB execution logging Alex Bennée
2015-08-04 12:17 ` Aurelien Jarno
2015-08-10 19:40 ` Christopher Covington
2016-02-03 18:45 ` Alex Bennée
2015-08-03 9:14 ` [Qemu-devel] [PATCH v4 06/11] qemu-log: support simple pid substitution in logfile Alex Bennée
2015-08-04 12:17 ` Aurelien Jarno
2015-08-03 9:14 ` [Qemu-devel] [PATCH v4 07/11] qemu-log: new option -dfilter to limit output Alex Bennée
2015-08-04 12:21 ` Aurelien Jarno
2015-08-10 16:59 ` Christopher Covington
2015-08-10 18:30 ` Alex Bennée
2015-08-03 9:14 ` [Qemu-devel] [PATCH v4 08/11] qemu-log: dfilter-ise exec, out_asm, and op_opt Alex Bennée
2015-08-04 12:22 ` Aurelien Jarno
2015-08-03 9:14 ` [Qemu-devel] [PATCH v4 09/11] target-arm: dfilter support for in_asm, op, opt_op Alex Bennée
2015-08-04 12:23 ` Aurelien Jarno
2015-08-04 14:44 ` Richard Henderson
2015-08-04 17:26 ` Alex Bennée
2015-08-04 18:11 ` Richard Henderson
2015-08-03 9:14 ` [Qemu-devel] [PATCH v4 10/11] vl.c: log system invocation when enabled Alex Bennée
2015-08-04 12:30 ` Aurelien Jarno
2015-08-04 12:40 ` Peter Maydell
2015-08-04 12:46 ` Aurelien Jarno
2015-08-04 13:14 ` Peter Maydell
2015-08-04 15:12 ` Alex Bennée
2015-08-03 9:14 ` [Qemu-devel] [PATCH v4 11/11] cputlb: modernise the debug support Alex Bennée
2015-08-04 12:33 ` Aurelien Jarno
2016-02-03 18:54 ` Alex Bennée
2016-02-03 19:05 ` Peter Maydell
2016-02-04 7:03 ` Alex Bennée [this message]
2015-09-11 7:54 ` [Qemu-devel] [PATCH v4 00/11] qemu-log, perfmap and other logging tweaks Michael Tokarev
2015-09-11 14:07 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpqlneii.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=crosthwaitepeter@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).