From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Greg Kurz <gkurz@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h}
Date: Thu, 07 Jan 2016 22:58:28 +0530 [thread overview]
Message-ID: <87wprlpadf.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160107171606.GF1457@citrix.com>
Wei Liu <wei.liu2@citrix.com> writes:
> On Thu, Jan 07, 2016 at 10:27:13PM +0530, Aneesh Kumar K.V wrote:
>> Wei Liu <wei.liu2@citrix.com> writes:
>>
>> > The vast majority of code in virtio-9p.c is actually generic code.
>> > Rename that file to 9p.c and move virtio specific code to
>> > virtio-9p-device.c. Rename virtio-9p.h to 9p.h and split out virtio
>> > specific code to new virtio-9p.h.
>> >
>> > Finally fix up virtio-pci.h header file inclusion.
>> >
>> > Note that V9fsState and V9fsPDU are still tied to virtio at the moment.
>> > They will be handled later.
>>
>> Can you split this to smaller patches as done for others.
>>
>
> I'm not sure what you're asking for. IMHO splitting out C and header
> file is better done in one single commit.
>
virtio-9p.h -> 9p.h one patch
virtio_p9_push_and_notify . There is one other instance of that
conversion in the next patch
handle_p9_output movement
V9fsThPool, what is that ?
-aneesh
next prev parent reply other threads:[~2016-01-07 17:29 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 19:05 [Qemu-devel] [PATCH 00/22] 9pfs: disentangling virtio and generic code Wei Liu
2016-01-05 19:05 ` [Qemu-devel] [PATCH 01/22] 9pfs: rename virtio-9p-coth.{c, h} to coth.{c, h} Wei Liu
2016-01-05 19:05 ` [Qemu-devel] [PATCH 02/22] 9pfs: rename virtio-9p-handle.c to 9p-handle.c Wei Liu
2016-01-05 19:05 ` [Qemu-devel] [PATCH 03/22] " Wei Liu
2016-01-06 11:22 ` Stefano Stabellini
2016-01-06 11:37 ` Wei Liu
2016-01-05 19:05 ` [Qemu-devel] [PATCH 04/22] 9pfs: rename virtio-9p-posix-acl.c to 9p-posix-acl.c Wei Liu
2016-01-05 19:05 ` [Qemu-devel] [PATCH 05/22] 9pfs: rename virtio-9p-proxy.{c, h} to 9p-proxy.{c, h} Wei Liu
2016-01-05 19:05 ` [Qemu-devel] [PATCH 06/22] 9pfs: rename virtio-9p-synth.{c, h} to 9p-synth.{c, h} Wei Liu
2016-01-05 19:05 ` [Qemu-devel] [PATCH 07/22] 9pfs: rename virtio-9p-xattr{, -user}.{c, h} to 9p-xattr{, -user}.{c, h} Wei Liu
2016-01-05 19:05 ` [Qemu-devel] [PATCH 08/22] 9pfs: merge hw/virtio/virtio-9p.h into hw/9pfs/virtio-9p.h Wei Liu
2016-01-05 19:05 ` [Qemu-devel] [PATCH 09/22] 9pfs: remove dead code Wei Liu
2016-01-07 16:41 ` Aneesh Kumar K.V
2016-01-07 16:57 ` Paolo Bonzini
2016-01-07 17:00 ` Greg Kurz
2016-01-05 19:05 ` [Qemu-devel] [PATCH 10/22] fsdev: break out 9p-marshal.{c, h} from virtio-9p-marshal.{c, h} Wei Liu
2016-01-07 16:42 ` Aneesh Kumar K.V
2016-01-07 17:07 ` Wei Liu
2016-01-05 19:05 ` [Qemu-devel] [PATCH 11/22] fsdev: 9p-marshal: introduce V9fsBlob Wei Liu
2016-01-05 19:05 ` [Qemu-devel] [PATCH 12/22] 9pfs: use V9fsBlob to transmit xattr Wei Liu
2016-01-07 16:49 ` Aneesh Kumar K.V
2016-01-07 17:03 ` Wei Liu
2016-01-05 19:05 ` [Qemu-devel] [PATCH 13/22] fsdev: rename virtio-9p-marshal.{c, h} to 9p-iov-marshal.{c, h} Wei Liu
2016-01-05 19:05 ` [Qemu-devel] [PATCH 14/22] 9pfs: PDU processing functions don't need to take V9fsState as argument Wei Liu
2016-01-05 19:05 ` [Qemu-devel] [PATCH 15/22] 9pfs: PDU processing functions should start pdu_ prefix Wei Liu
2016-01-05 19:05 ` [Qemu-devel] [PATCH 16/22] 9pfs: make pdu_{, un}marshal proper functions Wei Liu
2016-01-05 19:05 ` [Qemu-devel] [PATCH 17/22] 9pfs: factor out virtio_pdu_{, un}marshal Wei Liu
2016-01-05 19:05 ` [Qemu-devel] [PATCH 18/22] 9pfs: factor out pdu_push_and_notify Wei Liu
2016-01-05 19:05 ` [Qemu-devel] [PATCH 19/22] 9pfs: break out virtio_init_iov_from_pdu Wei Liu
2016-01-05 19:05 ` [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h} Wei Liu
2016-01-07 16:57 ` Aneesh Kumar K.V
2016-01-07 17:16 ` Wei Liu
2016-01-07 17:28 ` Aneesh Kumar K.V [this message]
2016-01-07 17:38 ` Greg Kurz
2016-01-07 17:47 ` Wei Liu
2016-01-07 19:07 ` Wei Liu
2016-01-05 19:06 ` [Qemu-devel] [PATCH 21/22] 9pfs: factor out v9fs_device_{, un}realize_common Wei Liu
2016-01-05 19:06 ` [Qemu-devel] [PATCH 22/22] 9pfs: disentangle V9fsState Wei Liu
2016-01-07 11:59 ` [Qemu-devel] [PATCH 00/22] 9pfs: disentangling virtio and generic code Stefano Stabellini
2016-01-07 12:32 ` Greg Kurz
2016-01-07 13:35 ` Greg Kurz
2016-01-07 15:17 ` Stefano Stabellini
2016-01-07 17:06 ` Aneesh Kumar K.V
2016-01-07 17:15 ` Greg Kurz
2016-01-07 17:04 ` Aneesh Kumar K.V
2016-01-07 17:54 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wprlpadf.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wei.liu2@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).