From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36676)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1aHENQ-0000lE-Jx
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:29:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1aHENN-0003kP-6B
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:29:32 -0500
Received: from e23smtp08.au.ibm.com ([202.81.31.141]:42957)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1aHENM-0003kL-Ii
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:29:29 -0500
Received: from localhost
	by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aneesh.kumar@linux.vnet.ibm.com>;
	Fri, 8 Jan 2016 03:29:25 +1000
Received: from d23relay06.au.ibm.com (d23relay06.au.ibm.com [9.185.63.219])
	by d23dlp01.au.ibm.com (Postfix) with ESMTP id 39B762CE8056
	for <qemu-devel@nongnu.org>; Fri,  8 Jan 2016 04:29:24 +1100 (EST)
Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97])
	by d23relay06.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id
	u07HT3YW20316356
	for <qemu-devel@nongnu.org>; Fri, 8 Jan 2016 04:29:14 +1100
Received: from d23av03.au.ibm.com (localhost [127.0.0.1])
	by d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	u07HSmGR007030
	for <qemu-devel@nongnu.org>; Fri, 8 Jan 2016 04:28:48 +1100
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
In-Reply-To: <20160107171606.GF1457@citrix.com>
References: <1452020761-24457-1-git-send-email-wei.liu2@citrix.com>
	<1452020761-24457-21-git-send-email-wei.liu2@citrix.com>
	<87egdtqqdy.fsf@linux.vnet.ibm.com>
	<20160107171606.GF1457@citrix.com>
Date: Thu, 07 Jan 2016 22:58:28 +0530
Message-ID: <87wprlpadf.fsf@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from
	virtio-9p.{c, h}
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wei Liu <wei.liu2@citrix.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Greg Kurz <gkurz@linux.vnet.ibm.com>

Wei Liu <wei.liu2@citrix.com> writes:

> On Thu, Jan 07, 2016 at 10:27:13PM +0530, Aneesh Kumar K.V wrote:
>> Wei Liu <wei.liu2@citrix.com> writes:
>> 
>> > The vast majority of code in virtio-9p.c is actually generic code.
>> > Rename that file to 9p.c and move virtio specific code to
>> > virtio-9p-device.c. Rename virtio-9p.h to 9p.h and split out virtio
>> > specific code to new virtio-9p.h.
>> >
>> > Finally fix up virtio-pci.h header file inclusion.
>> >
>> > Note that V9fsState and V9fsPDU are still tied to virtio at the moment.
>> > They will be handled later.
>> 
>> Can you split this to smaller patches as done for others.
>> 
>
> I'm not sure what you're asking for. IMHO splitting out C and header
> file is better done in one single commit.
>

virtio-9p.h -> 9p.h one patch
virtio_p9_push_and_notify . There is one other instance of that
conversion in the next patch
handle_p9_output movement
V9fsThPool, what is that ?

-aneesh