From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2LWc-00011r-95 for qemu-devel@nongnu.org; Thu, 25 Jul 2013 09:24:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2LWX-0003V3-H9 for qemu-devel@nongnu.org; Thu, 25 Jul 2013 09:24:10 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:53284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2LWX-0003PH-Bk for qemu-devel@nongnu.org; Thu, 25 Jul 2013 09:24:05 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 25 Jul 2013 14:23:21 +0100 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 72D316E8062 for ; Thu, 25 Jul 2013 09:23:12 -0400 (EDT) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r6PDNGhI32309492 for ; Thu, 25 Jul 2013 09:23:16 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r6PDNGTR024497 for ; Thu, 25 Jul 2013 10:23:16 -0300 From: Anthony Liguori In-Reply-To: <1374742849.6142.72.camel@pasglop> References: <1374501278-31549-1-git-send-email-pbonzini@redhat.com> <87ip02wqvn.fsf@codemonkey.ws> <1374729976.6142.61.camel@pasglop> <1374731256.6142.63.camel@pasglop> <51F0E47D.1060807@redhat.com> <1374742849.6142.72.camel@pasglop> Date: Thu, 25 Jul 2013 08:23:09 -0500 Message-ID: <87wqoe6af6.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 00/28] Memory API for 1.6: fix I/O port endianness mess List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt , Paolo Bonzini Cc: aik@ozlabs.ru, jan.kiszka@siemens.com, qemu-devel@nongnu.org, agraf@suse.de, hpoussin@reactos.org, aurelien@aurel32.net Benjamin Herrenschmidt writes: > On Thu, 2013-07-25 at 10:40 +0200, Paolo Bonzini wrote: >> In any case, let me reinforce point 6 above. The patches were not >> reverted because nobody posted the patches to do so. Until someone >> does >> so, it is basically Anthony's call. If he trusts people to fix the >> whole thing, he has no reason to revert anything. My track record of >> fixing mess is probably better than my track record of not causing it, >> so he didn't revert it. > > That's fine, I know you can fix stuff :-) I'm just really annoyed that > upstream qemu remained broken for so long (and still is) while the whole > thing derailed into a mostly pointless discussion on endianness and > nobody (including Alexey) hollered loud enough that the breakage was > fairly extensive It you want to prevent breakages, add unit tests. No patch will ever be merged into the tree if 'make check' fails. It's the ultimately way to prevent things like this from happening. I'd rather the tree is broken for a week and we get the proper fix merged than go through a big production of reverting things. Regards, Anthony Liguori > (BTW. The EHCI problem doesn't seem limited to SLOF, from what I > remember of what Alexey showed me today, the Linux EHCI driver also > segfaults qemu). > > Cheers, > Ben.