From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48599)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1UFpKx-0001LX-Qt
	for qemu-devel@nongnu.org; Wed, 13 Mar 2013 13:19:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1UFpKw-0005ge-Ga
	for qemu-devel@nongnu.org; Wed, 13 Mar 2013 13:19:35 -0400
Received: from mail-yh0-x22b.google.com ([2607:f8b0:4002:c01::22b]:35694)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1UFpKw-0005g9-CP
	for qemu-devel@nongnu.org; Wed, 13 Mar 2013 13:19:34 -0400
Received: by mail-yh0-f43.google.com with SMTP id z6so213313yhz.16
	for <qemu-devel@nongnu.org>; Wed, 13 Mar 2013 10:19:33 -0700 (PDT)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <17cefde0a8d7807294bab95e93c3328a20d3f2ed.1362505276.git.amit.shah@redhat.com>
References: <cover.1362505276.git.amit.shah@redhat.com>
	<17cefde0a8d7807294bab95e93c3328a20d3f2ed.1362505276.git.amit.shah@redhat.com>
Date: Wed, 13 Mar 2013 12:19:30 -0500
Message-ID: <87wqtb5ial.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH 17/20] qemu-char: move text console init to
	console.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>, qemu list <qemu-devel@nongnu.org>

Amit Shah <amit.shah@redhat.com> writes:

> From: Anthony Liguori <aliguori@us.ibm.com>
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>

This patch broke vc switching in GTK.

> ---
>  qemu-char.c  | 1 -
>  ui/console.c | 7 +++++++
>  2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index cf02cab..b82d643 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -3663,7 +3663,6 @@ static void register_types(void)
>      register_char_driver("null", qemu_chr_open_null);
>      register_char_driver("socket", qemu_chr_open_socket);
>      register_char_driver("udp", qemu_chr_open_udp);
> -    register_char_driver("vc", vc_init);
>      register_char_driver("memory", qemu_chr_open_ringbuf);
>  #ifdef _WIN32
>      register_char_driver("file", qemu_chr_open_win_file_out);
> diff --git a/ui/console.c b/ui/console.c
> index 0d95f32..83a6fa3 100644
> --- a/ui/console.c
> +++ b/ui/console.c
> @@ -1739,3 +1739,10 @@ PixelFormat qemu_default_pixelformat(int bpp)
>      }
>      return pf;
>  }
> +
> +static void register_types(void)
> +{
> +    register_char_driver("vc", text_console_init);

This should be:

       register_char_driver("vc", vc_init);

Patch on the way...

Regards,

Anthony Liguori

> +}
> +
> +type_init(register_types);
> -- 
> 1.8.1.2