From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFo6A-0003dE-7I for qemu-devel@nongnu.org; Wed, 13 Mar 2013 12:00:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFo61-0008SA-GX for qemu-devel@nongnu.org; Wed, 13 Mar 2013 12:00:14 -0400 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:43191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFo60-0008Oq-U3 for qemu-devel@nongnu.org; Wed, 13 Mar 2013 12:00:05 -0400 Received: from /spool/local by e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 14 Mar 2013 01:55:40 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 920F12CE804A for ; Thu, 14 Mar 2013 02:59:55 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2DFxqRF5702106 for ; Thu, 14 Mar 2013 02:59:52 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2DFxts0001639 for ; Thu, 14 Mar 2013 02:59:55 +1100 From: Anthony Liguori In-Reply-To: <51408C70.7010603@redhat.com> References: <1363169922-24335-1-git-send-email-kraxel@redhat.com> <87k3pbiiur.fsf@codemonkey.ws> <51408C70.7010603@redhat.com> Date: Wed, 13 Mar 2013 10:59:48 -0500 Message-ID: <87wqtbnvd7.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] chardev: add vte chardev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Gerd Hoffmann writes: > On 03/13/13 13:29, Anthony Liguori wrote: >> Gerd Hoffmann writes: >> >>> Kill the dirty hack which hooks gtk vte initialization into the >>> qemu consoles subsystem. The vte terminals are not related to qemu >>> consoles at all. This simply doesn't belong there and it stands in >>> the way when cleaning up the qemu consoles subsystem. So fix it >>> up, quickly, before it sneaks into a release. >> >> >> My only concern is that if someone had a command line like: >> >> qemu -serial stdio -monitor vc >> >> It now breaks with your series. > > Yes. I'm not worried. The switch to gtk is a pretty big one anyway > with a bunch of user interface changes. If we want avoid surprises for > the user at any cost we must not make gtk the default ui. > > Also: Once I'm done with the console cleanup it will be easy to make > 'vc' actually work with gtk. Please no. 'vc' needs to die. I don't want anyone using it... >> 'vc' is a graphical chardev and it should be up to what UI layer to >> decide how to express it > > No. > > 'vc' is a DisplaySurface filled by the qemu terminal emulation. It's > generic and works with any UI. QEMU shouldn't be in the terminal emulation business. > 'vte' is a chardev data stream linked up to the gtk vte widget. > Obviously works with gtk only. > >> What's the issue your having with console cleanup? > > It just doesn't fit into the QemuConsoles at all, and with multiple UI's > active (such as gtk+vnc at the same time) it doesn't make sense any > more. Okay, that makes a bit more sense. > > cheers, > Gerd