Re: [Qemu-devel] [PATCH v1 00/13] q35 patches for pci tree

[Anthony Liguori <aliguori@us.ibm.com>]

Jason Baron <jbaron@redhat.com> writes:

> Hi,
>
> Re-base of my previous q35 patches on top of Michael Tsirkin's pci
> tree.

I don't want this to come in through the pci tree.  This is not just
another PCI device and the ramifications are pretty big since this will
become the main machine model.

> Qemu bits for q35 support, I'm posting the seabios changes separately. The
> patches require '-M q35' and -L 'seabios dir with q35 changes' on the
> qemu command line. Hopefully, we can make it the default for x86 at some future
> point when we feel comfortable with it. I'm hoping these patches can be
> included for the 1.3 soft freeze.

Q35 is sufficiently important that I think we should push for it in 1.3
regardless of freeze dates.  The code is pretty close to being ready.
So let's not worry too much about merge dates and focusing on getting
the code up to the right level.

> The current patches have been tested with basic install testing and memory testing
> on f16, f17, windows 7 and windows 8. They can be run on the various BSD flavors
> by adding a 'piix4-ide' device to the pci bus. ie: -device piix4-ide. Patches
> have also been reported to work with a small dsdt change on OSX 10.6 as well.
>
> I've also dropped ACPI hotplug support completely - I simply haven't gotten a
> chance to clean this up yet. Hopefully, it is ok for this to come in a bit
> later.
>
> Git trees:
>
> git://github.com/jibaron/q35-qemu.git
> git://github.com/jibaron/q35-seabios.git
>
> Major Todo Items:
>
> -add ahci migration back (need to cover more fields, but basically works)
> -add ACPI hotplug support (pcie hotplug is currently working)

Since this is coming in as experimental for 1.3, I'm not overly
concerned about missing functionality.  I'm more concerned with code
structure and device modeling so let's focus on getting this right for
1.3.

Overall, the series looks pretty nice.  Thanks for all of your work
here!

Regards,

Anthony Liguori

>
>
> Isaku Yamahata (3):
>   pc/piix_pci: factor out smram/pam logic
>   pc, pc_piix: split out pc nic initialization
>   q35: Introduce q35 pc based chipset emulator
>
> Jan Kiszka (2):
>   q35: Suppress SMM BIOS initialization under KVM
>   q35: Add kvmclock support
>
> Jason Baron (8):
>   Back out add of i21154
>   blockdev: Introduce QEMUMachine->default_drive_if
>   blockdev: Introduce IF_AHCI
>   pc: Move ioapic_init() from pc_piix.c to pc.c
>   Add a fallback bios file search, if -L fails.
>   q35: automatically load the q35 dsdt table
>   q35: fill in usb pci slots with -usb
>   Fixup q35/ich9 Licenses
>
>  blockdev.c            |   23 +++-
>  blockdev.h            |   22 +++
>  hw/Makefile.objs      |    2 +-
>  hw/acpi_ich9.c        |   20 ++-
>  hw/boards.h           |    2 +-
>  hw/device-hotplug.c   |    2 +-
>  hw/highbank.c         |    2 +-
>  hw/i21154.c           |  113 ----------------
>  hw/i21154.h           |    9 --
>  hw/i386/Makefile.objs |    3 +-
>  hw/ich9.h             |    5 +-
>  hw/ide.h              |    1 +
>  hw/ide/core.c         |    9 ++
>  hw/ide/pci.c          |   19 +++
>  hw/ide/pci.h          |    1 +
>  hw/leon3.c            |    1 -
>  hw/lpc_ich9.c         |   32 +----
>  hw/mips_jazz.c        |    4 +-
>  hw/pam.c              |   87 ++++++++++++
>  hw/pam.h              |   97 ++++++++++++++
>  hw/pc.c               |   58 ++++++++
>  hw/pc.h               |    7 +
>  hw/pc_piix.c          |   38 +-----
>  hw/pc_q35.c           |  354 +++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/pc_sysfw.c         |    2 +-
>  hw/pci_ids.h          |    2 +
>  hw/piix_pci.c         |   68 ++--------
>  hw/puv3.c             |    1 -
>  hw/q35.c              |  315 +++++++++++++++++++++++++++++++++++++++++++
>  hw/q35.h              |  161 ++++++++++++++++++++++
>  hw/realview.c         |    6 +-
>  hw/smbus_ich9.c       |   14 +-
>  hw/spapr.c            |    2 +-
>  hw/sun4m.c            |   24 ++--
>  hw/versatilepb.c      |    4 +-
>  hw/vexpress.c         |    4 +-
>  hw/xilinx_zynq.c      |    2 +-
>  vl.c                  |   56 +++++---
>  38 files changed, 1272 insertions(+), 300 deletions(-)
>  delete mode 100644 hw/i21154.c
>  delete mode 100644 hw/i21154.h
>  create mode 100644 hw/pam.c
>  create mode 100644 hw/pam.h
>  create mode 100644 hw/pc_q35.c
>  create mode 100644 hw/q35.c
>  create mode 100644 hw/q35.h