From: Anthony Liguori <anthony@codemonkey.ws>
To: Blue Swirl <blauwirbel@gmail.com>, Stefan Weil <sw@weilnetz.de>
Cc: Jia Liu <proljc@gmail.com>,
qemu-devel@nongnu.org, Max Filippov <jcmvbkbc@gmail.com>,
Michael Walle <michael@walle.cc>,
Paul Brook <paul@codesourcery.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally
Date: Fri, 05 Oct 2012 11:07:05 -0500 [thread overview]
Message-ID: <87wqz4rjh2.fsf@codemonkey.ws> (raw)
In-Reply-To: <CAAu8pHt=tFYk4Hx5qFB6f8ezCdF4eyFgFNodnN-=WHF51xQnoQ@mail.gmail.com>
Blue Swirl <blauwirbel@gmail.com> writes:
> On Fri, Oct 5, 2012 at 5:39 AM, Stefan Weil <sw@weilnetz.de> wrote:
>> Am 05.10.2012 04:10, schrieb Anthony Liguori:
>>
>>> Avi Kivity <avi@redhat.com> writes:
>>>
>>>> The hassle and compile time overhead of maintaining both 32-bit and
>>>> 64-bit
>>>> capable source isn't worth the tiny performance advantage which is seen
>>>> on
>>>> a minority of configurations. Switch to compiling libhw only once, with
>>>> target_phys_addr_t unconditionally typedefed to uint64_t.
>>>>
>>>> Signed-off-by: Avi Kivity <avi@redhat.com>
>>>
>>> Applied. Thanks.
>>>
>>> Regards,
>>>
>>> Anthony Liguori
>>>
>>
>>
>> In a next step, we can remove libhw completely:
>>
>> All files from libhw/hw/*.o could as well be generated in hw/*.o,
>> and hw-obj should become common-obj.
>>
>> Or is there still a reason why libhw is needed?
>
> At least the trivial change to Makefile.objs does not work.
It's a little more complicated than that but not that hard.
I just sent a patch.
Regards,
Anthony Liguori
>
>>
>> Regards
>>
>> Stefan W.
>>
next prev parent reply other threads:[~2012-10-05 16:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 10:36 [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally Avi Kivity
2012-10-04 10:42 ` Edgar E. Iglesias
2012-10-04 11:42 ` Max Filippov
2012-10-04 13:56 ` Anthony Liguori
2012-10-04 16:54 ` Blue Swirl
2012-10-04 17:08 ` Michael Walle
2012-10-04 18:15 ` Stefan Weil
2012-10-07 10:25 ` Avi Kivity
2012-10-05 2:10 ` Anthony Liguori
2012-10-05 5:39 ` Stefan Weil
2012-10-05 15:46 ` Blue Swirl
2012-10-05 16:07 ` Anthony Liguori [this message]
2012-10-05 16:45 ` Peter Maydell
2012-10-07 13:16 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqz4rjh2.fsf@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=aurelien@aurel32.net \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=jcmvbkbc@gmail.com \
--cc=michael@walle.cc \
--cc=paul@codesourcery.com \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).