From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49473)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TKAQy-0006bS-4u
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 12:07:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TKAQr-0006wA-Lv
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 12:07:27 -0400
Received: from mail-ob0-f173.google.com ([209.85.214.173]:46394)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TKAQr-0006td-Gs
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 12:07:21 -0400
Received: by mail-ob0-f173.google.com with SMTP id wc18so1741803obb.4
	for <qemu-devel@nongnu.org>; Fri, 05 Oct 2012 09:07:09 -0700 (PDT)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <CAAu8pHt=tFYk4Hx5qFB6f8ezCdF4eyFgFNodnN-=WHF51xQnoQ@mail.gmail.com>
References: <1349346964-4151-1-git-send-email-avi@redhat.com>
	<87626phdn0.fsf@codemonkey.ws> <506E72A0.8010300@weilnetz.de>
	<CAAu8pHt=tFYk4Hx5qFB6f8ezCdF4eyFgFNodnN-=WHF51xQnoQ@mail.gmail.com>
Date: Fri, 05 Oct 2012 11:07:05 -0500
Message-ID: <87wqz4rjh2.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits
	unconditionally
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>, Stefan Weil <sw@weilnetz.de>
Cc: Jia Liu <proljc@gmail.com>, qemu-devel@nongnu.org, Max Filippov <jcmvbkbc@gmail.com>, Michael Walle <michael@walle.cc>, Paul Brook <paul@codesourcery.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Aurelien Jarno <aurelien@aurel32.net>, Avi Kivity <avi@redhat.com>

Blue Swirl <blauwirbel@gmail.com> writes:

> On Fri, Oct 5, 2012 at 5:39 AM, Stefan Weil <sw@weilnetz.de> wrote:
>> Am 05.10.2012 04:10, schrieb Anthony Liguori:
>>
>>> Avi Kivity <avi@redhat.com> writes:
>>>
>>>> The hassle and compile time overhead of maintaining both 32-bit and
>>>> 64-bit
>>>> capable source isn't worth the tiny performance advantage which is seen
>>>> on
>>>> a minority of configurations.  Switch to compiling libhw only once, with
>>>> target_phys_addr_t unconditionally typedefed to uint64_t.
>>>>
>>>> Signed-off-by: Avi Kivity <avi@redhat.com>
>>>
>>> Applied. Thanks.
>>>
>>> Regards,
>>>
>>> Anthony Liguori
>>>
>>
>>
>> In a next step, we can remove libhw completely:
>>
>> All files from libhw/hw/*.o could as well be generated in hw/*.o,
>> and hw-obj should become common-obj.
>>
>> Or is there still a reason why libhw is needed?
>
> At least the trivial change to Makefile.objs does not work.

It's a little more complicated than that but not that hard.

I just sent a patch.

Regards,

Anthony Liguori

>
>>
>> Regards
>>
>> Stefan W.
>>