From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9HjU-0000ms-Ao for qemu-devel@nongnu.org; Wed, 05 Sep 2012 11:41:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9HjM-0005tE-8Z for qemu-devel@nongnu.org; Wed, 05 Sep 2012 11:41:36 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:41185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9HjM-0005sD-3K for qemu-devel@nongnu.org; Wed, 05 Sep 2012 11:41:28 -0400 Received: by obbta14 with SMTP id ta14so399185obb.4 for ; Wed, 05 Sep 2012 08:41:27 -0700 (PDT) From: Anthony Liguori In-Reply-To: <50476F3E.7000100@redhat.com> References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503B62F4.9070500@suse.de> <87k3wjyy0e.fsf@codemonkey.ws> <503E227B.40904@suse.de> <874nndmrjs.fsf@codemonkey.ws> <50476F3E.7000100@redhat.com> Date: Wed, 05 Sep 2012 10:41:23 -0500 Message-ID: <87wr081nq4.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , Alexey Kardashevskiy , Marcelo Tosatti , qemu-devel@nongnu.org, Blue Swirl , Alex Williamson , Jan Kiszka , qemu-ppc , Andreas =?utf-8?Q?F=C3=A4rber?= Avi Kivity writes: > On 09/05/2012 12:00 AM, Anthony Liguori wrote: >>> >>> Why? The way this is being submitted I don't see why we should treat >>> Jan's patch any different from a patch by IBM or Samsung where we've >>> asked folks to fix the license to comply with what I thought was our new >>> policy (it does not even contain a from-x-on-GPLv2+ notice). >> >> Asking is one thing. Requiring is another. >> >> I would prefer that people submitted GPLv2+, but I don't think it should >> be a hard requirement. It means, among other things, that we cannot >> accept most code that originates from the Linux kernel. > > We could extend this to "require unless there is a reason to grant an > exception" if we wanted to (not saying I know whether we want to or > not). I don't want QEMU to be GPLv3. I don't like the terms of the GPLv3. I don't mind GPLv2+, if people want to share code from QEMU in GPLv3 projects, GPLv2+ enables that. But if new code is coming in and happens to be under GPLv2, that just means that the contribution cannot be used outside of QEMU in a GPLv3 project. That's fine and that's a decision for the submitter to make. Regards, Anthony Liguori > > > -- > error compiling committee.c: too many arguments to function